Skip to content

Desktop: Open links in default browser and prevent popups#3006

Merged
timon-schelling merged 6 commits intomasterfrom
desktop-open-links-in-default-browser
Aug 6, 2025
Merged

Desktop: Open links in default browser and prevent popups#3006
timon-schelling merged 6 commits intomasterfrom
desktop-open-links-in-default-browser

Conversation

@timon-schelling
Copy link
Copy Markdown
Member

@timon-schelling timon-schelling commented Aug 5, 2025

Partly closes #2540.

Open links in default browser and prevents CEF from opening popups

logs before the second commit:

2025-08-05T18:11:29.118324Z ERROR graphite_desktop::cef::internal::browser_process_life_span_handler: Browser tried to open a popup at URL: https://graphite.rs/
2025-08-05T18:11:29.335806Z ERROR graphite_desktop::cef::internal::browser_process_life_span_handler: Browser tried to open a popup at URL: https://graphite.rs/
2025-08-05T18:11:48.109077Z ERROR graphite_desktop::cef::internal::browser_process_life_span_handler: Browser tried to open a popup at URL: https://graphite.rs/
2025-08-05T18:11:48.273723Z ERROR graphite_desktop::cef::internal::browser_process_life_span_handler: Browser tried to open a popup at URL: https://graphite.rs/

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 5, 2025 20:01 Inactive
Comment thread desktop/src/app.rs Outdated
Comment thread desktop/Cargo.toml Outdated
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 5, 2025 20:17 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 5, 2025 20:27 Inactive
@timon-schelling timon-schelling enabled auto-merge (squash) August 6, 2025 13:52
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 6, 2025 15:20 Inactive
@timon-schelling timon-schelling merged commit 5f2432c into master Aug 6, 2025
4 checks passed
@timon-schelling timon-schelling deleted the desktop-open-links-in-default-browser branch August 6, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue: Adapt systems to support native platform APIs

3 participants