Skip to content

Desktop: Fix the Text tool not working with the hole punch#3012

Merged
TrueDoctor merged 3 commits intomasterfrom
desktop-fix-text-tool
Aug 7, 2025
Merged

Desktop: Fix the Text tool not working with the hole punch#3012
TrueDoctor merged 3 commits intomasterfrom
desktop-fix-text-tool

Conversation

@timon-schelling
Copy link
Copy Markdown
Member

@timon-schelling timon-schelling commented Aug 6, 2025

Closes #2997

Make viewport element transparent when hole punch is enabled
Instead of removing the viewport element completely we make it transparent
Allows the text tool to work

@timon-schelling timon-schelling requested a review from Keavon August 6, 2025 14:14
@github-actions github-actions Bot requested a deployment to graphite-dev (Preview) August 6, 2025 14:23 Abandoned
Instead of removing the viewport element completely we make it transparent
Allows the text tool to work
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 6, 2025 16:23 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 6, 2025 16:35 Inactive
@TrueDoctor TrueDoctor enabled auto-merge (squash) August 7, 2025 11:39
@Keavon Keavon changed the title Desktop: Fix text tool Desktop: Fix the Text tool not working with the hole punch Aug 7, 2025
@Keavon Keavon disabled auto-merge August 7, 2025 11:40
@Keavon Keavon enabled auto-merge (squash) August 7, 2025 11:40
@TrueDoctor TrueDoctor disabled auto-merge August 7, 2025 11:48
@TrueDoctor TrueDoctor merged commit b491cfc into master Aug 7, 2025
3 of 4 checks passed
@TrueDoctor TrueDoctor deleted the desktop-fix-text-tool branch August 7, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text input is broken on desktop

2 participants