Skip to content

Improve snapping performance#3067

Merged
TrueDoctor merged 4 commits intomasterfrom
faster-intersctions
Aug 20, 2025
Merged

Improve snapping performance#3067
TrueDoctor merged 4 commits intomasterfrom
faster-intersctions

Conversation

@TrueDoctor
Copy link
Copy Markdown
Member

@TrueDoctor TrueDoctor commented Aug 19, 2025

Fixes snapping performance regressions introduced in #3036

  • Use a fat line algorithm to speed up cubic cubic intersection checks
  • Implement termination criteria for degenerate intersection check cases
  • Implement faster nearest point calculation
  • Loosen bounding boxes which are only used for pruning

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 19, 2025 19:57 Inactive
@TrueDoctor TrueDoctor marked this pull request as ready for review August 20, 2025 07:27
@TrueDoctor TrueDoctor changed the title Use lyon_geom for intersection calculation of bezier segments Improve snapping performance Aug 20, 2025
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 20, 2025 07:43 Inactive
Comment thread editor/src/messages/tool/common_functionality/snapping/layer_snapper.rs Outdated
…napper.rs

Co-authored-by: Keavon Chambers <keavon@keavon.com>
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 20, 2025 08:18 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 20, 2025 08:39 Inactive
@TrueDoctor TrueDoctor merged commit 7c30f61 into master Aug 20, 2025
4 checks passed
@TrueDoctor TrueDoctor deleted the faster-intersctions branch August 20, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants