Skip to content

Show red connectors on a type-erroring node and accurate connector colors upstream of it#3110

Merged
Keavon merged 6 commits intomasterfrom
improve-editor-types
Nov 19, 2025
Merged

Show red connectors on a type-erroring node and accurate connector colors upstream of it#3110
Keavon merged 6 commits intomasterfrom
improve-editor-types

Conversation

@adamgerhant
Copy link
Copy Markdown
Collaborator

@adamgerhant adamgerhant commented Aug 30, 2025

Refactor how the editor handles type queries with an improved TypeSource enum and helper functions to reduce code duplication, better represent state, and prevent code duplication with a more abstracted interface.

Adds references to protonodes within document node definition networks.

Adds the Invalid type input color for the inputs to a node with an error.

Returns types for nodes upstream from a node graph type error

pub enum TypeSource {
	/// A type that has been compiled based on all upstream types.
	Compiled(Type),
	/// The type of value inputs.
	TaggedValue(Type),
	/// When the input/output is not compiled. The Type is from the document node definition, or () if it doesn't exist.
	Unknown,
	/// When there is a node graph error for the inputs to a node. The Type is from the document node definition, or () if it doesn't exist.
	Invalid,
	/// When there is an error in the algorithm for determining the input/output type (indicates a bug in the editor).
	Error(&'static str),
}

@adamgerhant adamgerhant force-pushed the improve-editor-types branch from 1fc7292 to 6c96ba8 Compare August 30, 2025 02:49
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 30, 2025 09:08 Inactive
@adamgerhant adamgerhant force-pushed the improve-editor-types branch from a04face to f60ef84 Compare August 31, 2025 04:17
@adamgerhant adamgerhant marked this pull request as ready for review August 31, 2025 04:20
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 31, 2025 04:33 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 31, 2025 04:51 Inactive
@adamgerhant adamgerhant force-pushed the improve-editor-types branch from 474939b to d98de76 Compare August 31, 2025 20:59
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 31, 2025 21:03 Inactive
@adamgerhant adamgerhant force-pushed the improve-editor-types branch 2 times, most recently from 34b6ae4 to 59d85cb Compare September 8, 2025 23:39
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) September 8, 2025 23:42 Inactive
@adamgerhant adamgerhant changed the base branch from master to typography September 8, 2025 23:58
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) September 9, 2025 00:05 Inactive
@adamgerhant adamgerhant changed the base branch from typography to master November 15, 2025 07:08
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 15, 2025 08:30 Inactive
@TrueDoctor
Copy link
Copy Markdown
Member

Still reviewing, I will also have to pay extra attention to whether the perf characteristics will have changed

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 17, 2025 22:32 Inactive
@Keavon Keavon force-pushed the improve-editor-types branch from ec24476 to 27d1f60 Compare November 17, 2025 22:59
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 17, 2025 23:22 Inactive
@Keavon Keavon force-pushed the improve-editor-types branch from 27d1f60 to f61359d Compare November 17, 2025 23:27
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 17, 2025 23:44 Inactive
@TrueDoctor
Copy link
Copy Markdown
Member

Alright, Approve from a code quality perspective. @Keavon I think we can merge this once you are happy with the functionality

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 18, 2025 20:29 Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 18, 2025

Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 27,767,075 (master) → 27,675,192 (HEAD) : $$\color{lime}-0.33\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.19%
D1mr                     352,730|    349,836          -0.82%
D1mw                     108,466|    108,737          +0.25%
DLmr                      32,228|     31,346          -2.74%
DLmw                      49,249|     47,516          -3.52%
Dr                     6,868,111|  6,835,644          -0.47%
Dw                     4,767,628|  4,756,480          -0.23%
EstimatedCycles       43,899,474| 43,698,642          -0.46%
I1MissRate                     0|          0         +13.15%
I1mr                      45,479|     51,291         +12.78%
ILmr                         855|        867          +1.40%
Ir                    27,767,075| 27,675,192          -0.33%
L1HitRate                     99|         99          -0.01%
L1hits                38,896,139| 38,757,452          -0.36%
LLHitRate                      1|          1          +1.71%
LLMissRate                     0|          0          -2.83%
LLdMissRate                    1|          1          -2.85%
LLhits                   424,343|    430,135          +1.36%
LLiMissRate                    0|          0          +1.74%
RamHitRate                     0|          0          -2.83%
RamHits                   82,332|     79,729          -3.16%
TotalRW               39,402,814| 39,267,316          -0.34%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 14,018,778 (master) → 13,891,973 (HEAD) : $$\color{lime}-0.90\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.53%
D1mr                     172,040|    169,064          -1.73%
D1mw                      53,349|     53,427          +0.15%
DLmr                         759|        515         -32.15%
DLmw                      14,171|     12,573         -11.28%
Dr                     3,472,022|  3,441,819          -0.87%
Dw                     2,400,482|  2,385,836          -0.61%
EstimatedCycles       21,351,072| 21,124,472          -1.06%
I1MissRate                     0|          0         +14.50%
I1mr                      22,281|     25,280         +13.46%
ILmr                         707|        704          -0.42%
Ir                    14,018,778| 13,891,973          -0.90%
L1HitRate                     99|         99          -0.01%
L1hits                19,643,612| 19,471,857          -0.87%
LLHitRate                      1|          1          +1.72%
LLMissRate                     0|          0         -11.03%
LLdMissRate                    0|          0         -11.66%
LLhits                   232,033|    233,979          +0.84%
LLiMissRate                    0|          0          +0.48%
RamHitRate                     0|          0         -11.03%
RamHits                   15,637|     13,792         -11.80%
TotalRW               19,891,282| 19,719,628          -0.86%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 3,099,021 (master) → 3,091,367 (HEAD) : $$\color{lime}-0.25\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.40%
D1mr                      36,826|     36,534          -0.79%
D1mw                      10,737|     10,694          -0.40%
DLmr                          13|         12          -7.69%
DLmw                       2,843|      3,030          +6.58%
Dr                       756,656|    753,877          -0.37%
Dw                       525,265|    524,135          -0.22%
EstimatedCycles        4,696,790|  4,691,525          -0.11%
I1MissRate                     0|          0         +11.11%
I1mr                       4,819|      5,341         +10.83%
ILmr                         688|        687          -0.15%
Ir                     3,099,021|  3,091,367          -0.25%
L1HitRate                     99|         99          -0.01%
L1hits                 4,328,560|  4,316,810          -0.27%
LLHitRate                      1|          1          +0.27%
LLMissRate                     0|          0          +5.50%
LLdMissRate                    0|          0          +6.84%
LLhits                    48,838|     48,840          +0.00%
LLiMissRate                    0|          0          +0.10%
RamHitRate                     0|          0          +5.50%
RamHits                    3,544|      3,729          +5.22%
TotalRW                4,380,942|  4,369,379          -0.26%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 13,701,609 (master) → 13,686,483 (HEAD) : $$\color{lime}-0.11\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.84%
D1mr                     174,537|    172,328          -1.27%
D1mw                      49,856|     49,656          -0.40%
DLmr                          61|         58          -4.92%
DLmw                      15,136|     12,883         -14.89%
Dr                     3,357,057|  3,346,564          -0.31%
Dw                     2,347,796|  2,344,612          -0.14%
EstimatedCycles       20,857,672| 20,754,521          -0.49%
I1MissRate                     0|          0          +4.33%
I1mr                      18,297|     19,069          +4.22%
ILmr                         818|        814          -0.49%
Ir                    13,701,609| 13,686,483          -0.11%
L1HitRate                     99|         99          +0.01%
L1hits                19,163,772| 19,136,606          -0.14%
LLHitRate                      1|          1          +0.42%
LLMissRate                     0|          0         -13.98%
LLdMissRate                    0|          0         -14.64%
LLhits                   226,675|    227,298          +0.27%
LLiMissRate                    0|          0          -0.38%
RamHitRate                     0|          0         -13.98%
RamHits                   16,015|     13,755         -14.11%
TotalRW               19,406,462| 19,377,659          -0.15%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 32,331,979 (master) → 31,996,831 (HEAD) : $$\color{lime}-1.04\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.21%
D1mr                     411,922|    405,581          -1.54%
D1mw                     123,760|    124,410          +0.53%
DLmr                      43,697|     42,456          -2.84%
DLmw                      55,625|     55,994          +0.66%
Dr                     7,967,682|  7,888,526          -0.99%
Dw                     5,537,307|  5,500,882          -0.66%
EstimatedCycles       51,185,882| 50,713,537          -0.92%
I1MissRate                     0|          0         +14.82%
I1mr                      50,204|     57,046         +13.63%
ILmr                         857|        855          -0.23%
Ir                    32,331,979| 31,996,831          -1.04%
L1HitRate                     99|         99          -0.02%
L1hits                45,251,082| 44,799,202          -1.00%
LLHitRate                      1|          1          +1.41%
LLMissRate                     0|          0          +0.11%
LLdMissRate                    1|          1          -0.02%
LLhits                   485,707|    487,732          +0.42%
LLiMissRate                    0|          0          +0.81%
RamHitRate                     0|          0          +0.11%
RamHits                  100,179|     99,305          -0.87%
TotalRW               45,836,968| 45,386,239          -0.98%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 21,294,719 (master) → 21,302,864 (HEAD) : $$\color{red}+0.04\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -1.16%
D1mr                     265,297|    261,078          -1.59%
D1mw                      77,760|     77,422          -0.43%
DLmr                      15,638|     14,803          -5.34%
DLmw                      28,271|     26,774          -5.30%
Dr                     5,272,495|  5,259,607          -0.24%
Dw                     3,656,728|  3,654,526          -0.06%
EstimatedCycles       33,073,126| 32,996,981          -0.23%
I1MissRate                     0|          0         +13.98%
I1mr                      33,854|     38,601         +14.02%
ILmr                         809|        809          +0.00%
Ir                    21,294,719| 21,302,864          +0.04%
L1HitRate                     99|         99          -0.00%
L1hits                29,847,031| 29,839,896          -0.02%
LLHitRate                      1|          1          +0.78%
LLMissRate                     0|          0          -5.19%
LLdMissRate                    0|          0          -5.15%
LLhits                   332,193|    334,715          +0.76%
LLiMissRate                    0|          0          -0.04%
RamHitRate                     0|          0          -5.19%
RamHits                   44,718|     42,386          -5.21%
TotalRW               30,223,942| 30,216,997          -0.02%

🔄 Executor Update

update_executor_iai::update_group::update_executor with_setup_0:setup_update_executor(isometric-fountain)
Instructions: 51,402,129 (master) → 46,725,473 (HEAD) : $$\color{lime}-9.10\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +3.20%
D1mr                     546,226|    504,336          -7.67%
D1mw                     128,112|    112,746         -11.99%
DLmr                       4,942|      3,642         -26.31%
DLmw                      21,108|     13,517         -35.96%
Dr                    13,167,288| 11,687,705         -11.24%
Dw                     9,025,879|  7,991,471         -11.46%
EstimatedCycles       77,124,908| 69,533,599          -9.84%
I1MissRate                     0|          0        +254.20%
I1mr                      10,845|     34,918        +221.97%
ILmr                         246|        206         -16.26%
Ir                    51,402,129| 46,725,473          -9.10%
L1HitRate                     99|         99          -0.05%
L1hits                72,910,113| 65,752,649          -9.82%
LLHitRate                      1|          1          +6.75%
LLMissRate                     0|          0         -26.81%
LLdMissRate                    0|          0         -25.72%
LLhits                   658,887|    634,635          -3.68%
LLiMissRate                    0|          0          -7.88%
RamHitRate                     0|          0         -26.81%
RamHits                   26,296|     17,365         -33.96%
TotalRW               73,595,296| 66,404,649          -9.77%

update_executor_iai::update_group::update_executor with_setup_1:setup_update_executor(painted-dreams)
Instructions: 25,401,237 (master) → 24,184,846 (HEAD) : $$\color{lime}-4.79\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +1.83%
D1mr                     266,153|    253,550          -4.74%
D1mw                      61,020|     56,413          -7.55%
DLmr                         994|        986          -0.80%
DLmw                       3,589|      4,567         +27.25%
Dr                     6,488,290|  6,050,553          -6.75%
Dw                     4,453,063|  4,129,393          -7.27%
EstimatedCycles       37,818,866| 35,860,352          -5.18%
I1MissRate                     0|          0        +258.27%
I1mr                       6,151|     20,982        +241.12%
ILmr                         183|        173          -5.46%
Ir                    25,401,237| 24,184,846          -4.79%
L1HitRate                     99|         99          -0.05%
L1hits                36,009,266| 34,033,847          -5.49%
LLHitRate                      1|          1          +4.68%
LLMissRate                     0|          0         +27.06%
LLdMissRate                    0|          0         +30.23%
LLhits                   328,558|    325,219          -1.02%
LLiMissRate                    0|          0          -0.71%
RamHitRate                     0|          0         +27.06%
RamHits                    4,766|      5,726         +20.14%
TotalRW               36,342,590| 34,364,792          -5.44%

update_executor_iai::update_group::update_executor with_setup_2:setup_update_executor(procedural-string-lights)
Instructions: 6,443,575 (master) → 6,259,057 (HEAD) : $$\color{lime}-2.86\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +5.78%
D1mr                      62,812|     66,044          +5.15%
D1mw                      15,668|     14,929          -4.72%
DLmr                         NaN|        NaN          +0.00%
DLmw                         442|        410          -7.24%
Dr                     1,632,013|  1,590,999          -2.51%
Dw                     1,119,704|  1,092,946          -2.39%
EstimatedCycles        9,539,146|  9,308,952          -2.41%
I1MissRate                     0|          0        +122.56%
I1mr                       2,841|      6,142        +116.19%
ILmr                         177|        173          -2.26%
Ir                     6,443,575|  6,259,057          -2.86%
L1HitRate                     99|         99          -0.09%
L1hits                 9,113,971|  8,855,887          -2.83%
LLHitRate                      1|          1         +10.25%
LLMissRate                     0|          0          -3.16%
LLdMissRate                    0|          0          -4.90%
LLhits                    80,702|     86,532          +7.22%
LLiMissRate                    0|          0          +0.62%
RamHitRate                     0|          0          -3.16%
RamHits                      619|        583          -5.82%
TotalRW                9,195,292|  8,943,002          -2.74%

update_executor_iai::update_group::update_executor with_setup_3:setup_update_executor(parametric-dunescape)
Instructions: 27,373,955 (master) → 28,118,931 (HEAD) : $$\color{red}+2.72\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -1.44%
D1mr                     276,750|    278,719          +0.71%
D1mw                      70,206|     70,741          +0.76%
DLmr                         204|        191          -6.37%
DLmw                       3,586|      3,903          +8.84%
Dr                     6,959,097|  7,111,595          +2.19%
Dw                     4,848,202|  4,954,905          +2.20%
EstimatedCycles       40,709,714| 41,782,007          +2.63%
I1MissRate                     0|          0        +217.73%
I1mr                       5,429|     17,719        +226.38%
ILmr                         174|        168          -3.45%
Ir                    27,373,955| 28,118,931          +2.72%
L1HitRate                     99|         99          -0.01%
L1hits                38,828,869| 39,818,252          +2.55%
LLHitRate                      1|          1          +1.56%
LLMissRate                     0|          0          +4.83%
LLdMissRate                    0|          0          +5.70%
LLhits                   348,421|    362,917          +4.16%
LLiMissRate                    0|          0          -6.01%
RamHitRate                     0|          0          +4.83%
RamHits                    3,964|      4,262          +7.52%
TotalRW               39,181,254| 40,185,431          +2.56%

update_executor_iai::update_group::update_executor with_setup_4:setup_update_executor(red-dress)
Instructions: 60,631,433 (master) → 63,894,274 (HEAD) : $$\color{red}+5.38\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.76%
D1mr                     637,471|    664,658          +4.26%
D1mw                     150,671|    158,607          +5.27%
DLmr                      10,590|     14,467         +36.61%
DLmw                      33,938|     34,126          +0.55%
Dr                    15,480,079| 16,258,422          +5.03%
Dw                    10,595,570| 11,187,935          +5.59%
EstimatedCycles       91,250,714| 96,278,103          +5.51%
I1MissRate                     0|          0        +278.83%
I1mr                      10,986|     43,858        +299.22%
ILmr                         376|        373          -0.80%
Ir                    60,631,433| 63,894,274          +5.38%
L1HitRate                     99|         99          -0.03%
L1hits                85,907,954| 90,473,508          +5.31%
LLHitRate                      1|          1          +2.97%
LLMissRate                     0|          0          +3.51%
LLdMissRate                    0|          0          +3.68%
LLhits                   754,224|    818,157          +8.48%
LLiMissRate                    0|          0          -5.86%
RamHitRate                     0|          0          +3.51%
RamHits                   44,904|     48,966          +9.05%
TotalRW               86,707,082| 91,340,631          +5.34%

update_executor_iai::update_group::update_executor with_setup_5:setup_update_executor(valley-of-spires)
Instructions: 37,440,328 (master) → 36,093,404 (HEAD) : $$\color{lime}-3.60\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.36%
D1mr                     397,980|    383,766          -3.57%
D1mw                      89,963|     87,421          -2.83%
DLmr                       2,748|      2,664          -3.06%
DLmw                       7,728|     10,425         +34.90%
Dr                     9,481,815|  9,103,250          -3.99%
Dw                     6,445,135|  6,221,983          -3.46%
EstimatedCycles       55,672,452| 53,818,151          -3.33%
I1MissRate                     0|          0        +264.85%
I1mr                       8,303|     29,204        +251.73%
ILmr                         197|        176         -10.66%
Ir                    37,440,328| 36,093,404          -3.60%
L1HitRate                     99|         99          -0.04%
L1hits                52,871,032| 50,918,246          -3.69%
LLHitRate                      1|          1          +4.12%
LLMissRate                     0|          0         +29.00%
LLdMissRate                    0|          0         +29.85%
LLhits                   485,573|    487,126          +0.32%
LLiMissRate                    0|          0          -7.33%
RamHitRate                     0|          0         +29.00%
RamHits                   10,673|     13,265         +24.29%
TotalRW               53,367,278| 51,418,637          -3.65%

🚀 Render: Cold Execution

run_once_iai::run_once_group::run_once with_setup_0:setup_run_once(isometric-fountain)
Instructions: 23,272,030 (master) → 22,480,569 (HEAD) : $$\color{lime}-3.40\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.50%
D1mr                     290,941|    273,926          -5.85%
D1mw                      59,653|     59,021          -1.06%
DLmr                       9,012|      8,212          -8.88%
DLmw                       9,044|     10,110         +11.79%
Dr                     6,110,423|  5,839,381          -4.44%
Dw                     4,130,778|  3,934,840          -4.74%
EstimatedCycles       36,180,885| 34,841,366          -3.70%
I1MissRate                     1|          1          +1.16%
I1mr                     138,802|    135,632          -2.28%
ILmr                       5,613|      5,420          -3.44%
Ir                    23,272,030| 22,480,569          -3.40%
L1HitRate                     99|         99          +0.01%
L1hits                33,023,835| 31,786,211          -3.75%
LLHitRate                      1|          1          -0.76%
LLMissRate                     0|          0          +4.22%
LLdMissRate                    0|          0          +6.32%
LLhits                   465,727|    444,837          -4.49%
LLiMissRate                    0|          0          -0.04%
RamHitRate                     0|          0          +4.22%
RamHits                   23,669|     23,742          +0.31%
TotalRW               33,513,231| 32,254,790          -3.76%

run_once_iai::run_once_group::run_once with_setup_1:setup_run_once(painted-dreams)
Instructions: 79,958,761 (master) → 78,714,872 (HEAD) : $$\color{lime}-1.56\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          +1.30%
D1mr                     418,628|    412,822          -1.39%
D1mw                     196,652|    193,900          -1.40%
DLmr                       3,971|      3,903          -1.71%
DLmw                      27,758|     20,040         -27.80%
Dr                    19,255,869| 18,811,201          -2.31%
Dw                    12,806,424| 12,399,330          -3.18%
EstimatedCycles      116,418,362|114,044,425          -2.04%
I1MissRate                     0|          0          +1.73%
I1mr                     187,692|    187,961          +0.14%
ILmr                       7,785|      7,400          -4.95%
Ir                    79,958,761| 78,714,872          -1.56%
L1HitRate                     99|         99          -0.01%
L1hits               111,218,082|109,130,720          -1.88%
LLHitRate                      1|          1          +1.89%
LLMissRate                     0|          0         -19.17%
LLdMissRate                    0|          0         -22.48%
LLhits                   763,458|    763,340          -0.02%
LLiMissRate                    0|          0          -3.44%
RamHitRate                     0|          0         -19.17%
RamHits                   39,514|     31,343         -20.68%
TotalRW              112,021,054|109,925,403          -1.87%

run_once_iai::run_once_group::run_once with_setup_2:setup_run_once(procedural-string-lights)
Instructions: 10,798,731 (master) → 10,490,416 (HEAD) : $$\color{lime}-2.86\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          -3.53%
D1mr                      65,284|     59,331          -9.12%
D1mw                      23,096|     23,788          +3.00%
DLmr                         483|        428         -11.39%
DLmw                         912|      1,206         +32.24%
Dr                     2,686,052|  2,612,958          -2.72%
Dw                     1,929,996|  1,887,178          -2.22%
EstimatedCycles       16,146,123| 15,707,866          -2.71%
I1MissRate                     0|          0          +5.62%
I1mr                      48,631|     49,897          +2.60%
ILmr                       4,715|      4,541          -3.69%
Ir                    10,798,731| 10,490,416          -2.86%
L1HitRate                     99|         99          +0.00%
L1hits                15,277,768| 14,857,536          -2.75%
LLHitRate                      1|          1          -0.36%
LLMissRate                     0|          0          +3.92%
LLdMissRate                    0|          0         +20.15%
LLhits                   130,901|    126,841          -3.10%
LLiMissRate                    0|          0          -0.86%
RamHitRate                     0|          0          +3.92%
RamHits                    6,110|      6,175          +1.06%
TotalRW               15,414,779| 14,990,552          -2.75%

run_once_iai::run_once_group::run_once with_setup_3:setup_run_once(parametric-dunescape)
Instructions: 23,545,375 (master) → 23,461,199 (HEAD) : $$\color{lime}-0.36\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          +0.91%
D1mr                     157,781|    160,533          +1.74%
D1mw                      62,585|     64,414          +2.92%
DLmr                       2,286|      2,290          +0.17%
DLmw                       5,817|      3,297         -43.32%
Dr                     5,653,534|  5,697,504          +0.78%
Dw                     3,733,328|  3,797,757          +1.73%
EstimatedCycles       34,451,081| 34,428,716          -0.06%
I1MissRate                     0|          0          +5.72%
I1mr                      69,150|     72,842          +5.34%
ILmr                       3,923|      3,783          -3.57%
Ir                    23,545,375| 23,461,199          -0.36%
L1HitRate                     99|         99          -0.02%
L1hits                32,642,721| 32,658,671          +0.05%
LLHitRate                      1|          1          +3.86%
LLMissRate                     0|          0         -22.14%
LLdMissRate                    0|          0         -31.84%
LLhits                   277,490|    288,419          +3.94%
LLiMissRate                    0|          0          -3.22%
RamHitRate                     0|          0         -22.14%
RamHits                   12,026|      9,370         -22.09%
TotalRW               32,932,237| 32,956,460          +0.07%

run_once_iai::run_once_group::run_once with_setup_4:setup_run_once(red-dress)
Instructions: 1,802,759,904 (master) → 1,795,741,878 (HEAD) : $$\color{lime}-0.39\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     0|          0          -1.58%
D1mr                   1,897,840|  1,891,617          -0.33%
D1mw                     882,923|    885,870          +0.33%
DLmr                     453,747|    461,992          +1.82%
DLmw                     561,285|    524,760          -6.51%
Dr                   425,204,223|432,764,877          +1.78%
Dw                   276,389,699|279,252,739          +1.04%
EstimatedCycles      2,551,005,500|2,553,712,262          +0.11%
I1MissRate                     0|          0          +3.87%
I1mr                   1,226,343|  1,268,830          +3.46%
ILmr                       5,743|      5,498          -4.27%
Ir                   1,802,759,904|1,795,741,878          -0.39%
L1HitRate                    100|        100          -0.00%
L1hits               2,500,346,720|2,503,713,177          +0.13%
LLHitRate                      0|          0          +2.13%
LLMissRate                     0|          0          -2.93%
LLdMissRate                    0|          0          -4.21%
LLhits                 2,986,331|  3,054,067          +2.27%
LLiMissRate                    0|          0          -3.89%
RamHitRate                     0|          0          -2.93%
RamHits                1,020,775|    992,250          -2.79%
TotalRW              2,504,353,826|2,507,759,494          +0.14%

run_once_iai::run_once_group::run_once with_setup_5:setup_run_once(valley-of-spires)
Instructions: 20,819,146 (master) → 20,555,274 (HEAD) : $$\color{lime}-1.27\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.55%
D1mr                     225,503|    222,528          -1.32%
D1mw                      52,583|     54,116          +2.92%
DLmr                       5,710|      5,667          -0.75%
DLmw                       6,403|      6,922          +8.11%
Dr                     5,246,375|  5,229,829          -0.32%
Dw                     3,520,712|  3,539,958          +0.55%
EstimatedCycles       31,619,147| 31,353,773          -0.84%
I1MissRate                     1|          1          -0.51%
I1mr                     111,110|    109,139          -1.77%
ILmr                       3,758|      3,597          -4.28%
Ir                    20,819,146| 20,555,274          -1.27%
L1HitRate                     99|         99          -0.00%
L1hits                29,197,037| 28,939,278          -0.88%
LLHitRate                      1|          1          -0.12%
LLMissRate                     0|          0          +2.89%
LLdMissRate                    0|          0          +3.90%
LLhits                   373,325|    369,597          -1.00%
LLiMissRate                    0|          0          -3.06%
RamHitRate                     0|          0          +2.89%
RamHits                   15,871|     16,186          +1.98%
TotalRW               29,586,233| 29,325,061          -0.88%

⚡ Render: Cached Execution

run_cached_iai::run_cached_group::run_cached with_setup_0:setup_run_cached(isometric-fountain)
Instructions: 8,233,476 (master) → 7,917,660 (HEAD) : $$\color{lime}-3.84\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          5          -2.31%
D1mr                     207,909|    195,693          -5.88%
D1mw                       7,539|      7,485          -0.72%
DLmr                       2,039|      1,963          -3.73%
DLmw                         163|        136         -16.56%
Dr                     2,489,991|  2,400,992          -3.57%
Dw                     1,469,129|  1,420,790          -3.29%
EstimatedCycles       13,129,086| 12,622,986          -3.85%
I1MissRate                     0|          0          -2.18%
I1mr                         742|        698          -5.93%
ILmr                         189|        169         -10.58%
Ir                     8,233,476|  7,917,660          -3.84%
L1HitRate                     98|         98          +0.04%
L1hits                11,976,406| 11,535,566          -3.68%
LLHitRate                      2|          2          -2.06%
LLMissRate                     0|          0          -1.48%
LLdMissRate                    0|          0          -1.25%
LLhits                   213,799|    201,608          -5.70%
LLiMissRate                    0|          0          -7.02%
RamHitRate                     0|          0          -1.48%
RamHits                    2,391|      2,268          -5.14%
TotalRW               12,192,596| 11,739,442          -3.72%

run_cached_iai::run_cached_group::run_cached with_setup_1:setup_run_cached(painted-dreams)
Instructions: 6,031,097 (master) → 6,070,010 (HEAD) : $$\color{red}+0.65\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          4          -6.75%
D1mr                     132,310|    129,642          -2.02%
D1mw                       7,170|      9,097         +26.88%
DLmr                         351|        248         -29.34%
DLmw                         121|         10         -91.74%
Dr                     1,874,767|  1,970,000          +5.08%
Dw                     1,122,726|  1,227,518          +9.33%
EstimatedCycles        9,608,842|  9,837,868          +2.38%
I1MissRate                     0|          0          -8.02%
I1mr                         768|        711          -7.42%
ILmr                         170|        160          -5.88%
Ir                     6,031,097|  6,070,010          +0.65%
L1HitRate                     98|         98          +0.05%
L1hits                 8,888,342|  9,128,078          +2.70%
LLHitRate                      2|          2          -2.98%
LLMissRate                     0|          0         -36.57%
LLdMissRate                    0|          0         -48.76%
LLhits                   139,606|    139,032          -0.41%
LLiMissRate                    0|          0          -6.49%
RamHitRate                     0|          0         -36.57%
RamHits                      642|        418         -34.89%
TotalRW                9,028,590|  9,267,528          +2.65%

run_cached_iai::run_cached_group::run_cached with_setup_2:setup_run_cached(parametric-dunescape)
Instructions: 3,731,903 (master) → 3,754,228 (HEAD) : $$\color{red}+0.60\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          5          +0.03%
D1mr                      93,322|     93,852          +0.57%
D1mw                       7,731|      7,670          -0.79%
DLmr                          49|         43         -12.24%
DLmw                          20|         39         +95.00%
Dr                     1,272,472|  1,278,089          +0.44%
Dw                       836,645|    840,198          +0.42%
EstimatedCycles        6,254,988|  6,288,021          +0.53%
I1MissRate                     0|          0         -14.08%
I1mr                         789|        682         -13.56%
ILmr                         151|        141          -6.62%
Ir                     3,731,903|  3,754,228          +0.60%
L1HitRate                     98|         98          +0.00%
L1hits                 5,739,178|  5,770,311          +0.54%
LLHitRate                      2|          2          -0.18%
LLMissRate                     0|          0          +0.82%
LLdMissRate                    0|          0         +18.33%
LLhits                   101,622|    101,981          +0.35%
LLiMissRate                    0|          0          -7.18%
RamHitRate                     0|          0          +0.82%
RamHits                      220|        223          +1.36%
TotalRW                5,841,020|  5,872,515          +0.54%

run_cached_iai::run_cached_group::run_cached with_setup_3:setup_run_cached(red-dress)
Instructions: 35,371,732 (master) → 35,574,111 (HEAD) : $$\color{red}+0.57\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          5          -0.38%
D1mr                     686,324|    687,693          +0.20%
D1mw                     101,213|    101,128          -0.08%
DLmr                     300,906|    302,822          +0.64%
DLmw                      59,781|     59,734          -0.08%
Dr                    10,087,967| 10,143,557          +0.55%
Dw                     5,473,447|  5,503,161          +0.54%
EstimatedCycles       64,929,372| 65,278,211          +0.54%
I1MissRate                     0|          0          -4.91%
I1mr                         802|        767          -4.36%
ILmr                         742|        745          +0.40%
Ir                    35,371,732| 35,574,111          +0.57%
L1HitRate                     98|         98          +0.01%
L1hits                50,144,807| 50,431,241          +0.57%
LLHitRate                      1|          1          -0.71%
LLMissRate                     1|          1          -0.05%
LLdMissRate                    2|          2          -0.03%
LLhits                   426,910|    426,287          -0.15%
LLiMissRate                    0|          0          -0.17%
RamHitRate                     1|          1          -0.05%
RamHits                  361,429|    363,301          +0.52%
TotalRW               50,933,146| 51,220,829          +0.56%

run_cached_iai::run_cached_group::run_cached with_setup_4:setup_run_cached(valley-of-spires)
Instructions: 6,403,755 (master) → 6,367,853 (HEAD) : $$\color{lime}-0.56\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          5          -3.87%
D1mr                     158,723|    155,475          -2.05%
D1mw                       6,507|      7,388         +13.54%
DLmr                         239|        203         -15.06%
DLmw                         168|        180          +7.14%
Dr                     1,912,330|  1,944,775          +1.70%
Dw                     1,117,048|  1,161,508          +3.98%
EstimatedCycles       10,114,437| 10,144,638          +0.30%
I1MissRate                     0|          0          -5.08%
I1mr                         731|        690          -5.61%
ILmr                         175|        160          -8.57%
Ir                     6,403,755|  6,367,853          -0.56%
L1HitRate                     98|         98          +0.03%
L1hits                 9,267,172|  9,310,583          +0.47%
LLHitRate                      2|          2          -1.86%
LLMissRate                     0|          0          -7.10%
LLdMissRate                    0|          0          -8.23%
LLhits                   165,379|    163,010          -1.43%
LLiMissRate                    0|          0          -8.06%
RamHitRate                     0|          0          -7.10%
RamHits                      582|        543          -6.70%
TotalRW                9,433,133|  9,474,136          +0.43%

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 18, 2025 22:03 Inactive
@Keavon Keavon changed the title Improve editor types Show red connectors on a type-erroring node and refactor TypeSource enum Nov 18, 2025
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 19, 2025 00:45 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 19, 2025 00:58 Inactive
@adamgerhant adamgerhant changed the title Show red connectors on a type-erroring node and refactor TypeSource enum Show red connectors on a type-erroring node and accurate connector colors upstream of it Nov 19, 2025
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 19, 2025 02:03 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 19, 2025 02:52 Inactive
@Keavon Keavon enabled auto-merge (squash) November 19, 2025 02:58
@Keavon Keavon merged commit 06484ef into master Nov 19, 2025
4 checks passed
@Keavon Keavon deleted the improve-editor-types branch November 19, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants