Native background render node

.devcontainer/devcontainer.json

@@ -23,7 +23,6 @@
 				"streetsidesoftware.code-spell-checker",
 				// Helpful
 				"mhutchie.git-graph",
-				"waderyan.gitblame",
 				"qezhu.gitlink",
 				"wmaurer.change-case"
 			]

.github/workflows/comment-profiling-changes.yaml

@@ -1,14 +1,15 @@
 name: Profiling Changes
 
 on:
-  pull_request:
+  pull_request: {}
 
 env:
   CARGO_TERM_COLOR: always
 
 jobs:
   profile:
     runs-on: ubuntu-latest
+    continue-on-error: true
     steps:
       - uses: actions/checkout@v4
         with:
@@ -33,12 +34,12 @@ jobs:
         uses: actions/cache@v4
         with:
           path: ~/.cargo/bin/iai-callgrind-runner
-          key: ${{ runner.os }}-iai-callgrind-runner-0.12.3
+          key: ${{ runner.os }}-iai-callgrind-runner-0.16.1
 
       - name: Install iai-callgrind
         if: steps.cache-iai.outputs.cache-hit != 'true'
         run: |
-          cargo install iai-callgrind-runner@0.12.3
+          cargo install iai-callgrind-runner@0.16.1
 
       - name: Checkout master branch
         run: |
@@ -63,7 +64,7 @@ jobs:
         run: |
           # Compile benchmarks
           cargo bench --bench compile_demo_art_iai -- --save-baseline=master
-          
+
           # Runtime benchmarks
           cargo bench --bench update_executor_iai -- --save-baseline=master
           cargo bench --bench run_once_iai -- --save-baseline=master
@@ -74,32 +75,14 @@ jobs:
           git checkout ${{ github.event.pull_request.head.sha }}
 
       - name: Run PR benchmarks
-        id: benchmark
         run: |
           # Compile benchmarks
-          COMPILE_OUTPUT=$(cargo bench --bench compile_demo_art_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g')
-
-          # Runtime benchmarks
-          UPDATE_OUTPUT=$(cargo bench --bench update_executor_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g')
-          RUN_ONCE_OUTPUT=$(cargo bench --bench run_once_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g')
-          RUN_CACHED_OUTPUT=$(cargo bench --bench run_cached_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g')
-
-          # Store outputs
-          echo "COMPILE_OUTPUT<<EOF" >> $GITHUB_OUTPUT
-          echo "$COMPILE_OUTPUT" >> $GITHUB_OUTPUT
-          echo "EOF" >> $GITHUB_OUTPUT
-
-          echo "UPDATE_OUTPUT<<EOF" >> $GITHUB_OUTPUT
-          echo "$UPDATE_OUTPUT" >> $GITHUB_OUTPUT
-          echo "EOF" >> $GITHUB_OUTPUT
-
-          echo "RUN_ONCE_OUTPUT<<EOF" >> $GITHUB_OUTPUT
-          echo "$RUN_ONCE_OUTPUT" >> $GITHUB_OUTPUT
-          echo "EOF" >> $GITHUB_OUTPUT
-
-          echo "RUN_CACHED_OUTPUT<<EOF" >> $GITHUB_OUTPUT
-          echo "$RUN_CACHED_OUTPUT" >> $GITHUB_OUTPUT
-          echo "EOF" >> $GITHUB_OUTPUT
+          cargo bench --bench compile_demo_art_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g' > /tmp/compile_output.json
+
+          # Runtime benchmarks  
+          cargo bench --bench update_executor_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g' > /tmp/update_output.json
+          cargo bench --bench run_once_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g' > /tmp/run_once_output.json
+          cargo bench --bench run_cached_iai -- --baseline=master --output-format=json | jq -sc | sed 's/\\"//g' > /tmp/run_cached_output.json
 
       - name: Make old comments collapsed by default
         uses: actions/github-script@v7
@@ -131,11 +114,13 @@ jobs:
         with:
           github-token: ${{secrets.GITHUB_TOKEN}}
           script: |
-            const compileOutput = JSON.parse(`${{ steps.benchmark.outputs.COMPILE_OUTPUT }}`);
-            const updateOutput = JSON.parse(`${{ steps.benchmark.outputs.UPDATE_OUTPUT }}`);
-            const runOnceOutput = JSON.parse(`${{ steps.benchmark.outputs.RUN_ONCE_OUTPUT }}`);
-            const runCachedOutput = JSON.parse(`${{ steps.benchmark.outputs.RUN_CACHED_OUTPUT }}`);
-
+            const fs = require('fs');
+
+            const compileOutput = JSON.parse(fs.readFileSync('/tmp/compile_output.json', 'utf8'));
+            const updateOutput = JSON.parse(fs.readFileSync('/tmp/update_output.json', 'utf8'));  
+            const runOnceOutput = JSON.parse(fs.readFileSync('/tmp/run_once_output.json', 'utf8'));
+            const runCachedOutput = JSON.parse(fs.readFileSync('/tmp/run_cached_output.json', 'utf8'));
+
             let significantChanges = false;
             let commentBody = "";
 
@@ -162,11 +147,18 @@ jobs:
               let hasSignificantChanges = false;
 
               for (const benchmark of benchmarkOutput) {
-                if (benchmark.callgrind_summary && benchmark.callgrind_summary.summaries) {
-                  const summary = benchmark.callgrind_summary.summaries[0];
-                  const irDiff = summary.events.Ir;
-
-                  if (irDiff.diff_pct !== null) {
+                if (benchmark.profiles && benchmark.profiles.length > 0) {
+                  const profile = benchmark.profiles[0];
+                  if (profile.summaries && profile.summaries.parts && profile.summaries.parts.length > 0) {
+                    const part = profile.summaries.parts[0];
+                    if (part.metrics_summary && part.metrics_summary.Callgrind && part.metrics_summary.Callgrind.Ir) {
+                      const irData = part.metrics_summary.Callgrind.Ir;
+                      if (irData.diffs && irData.diffs.diff_pct !== null) {
+                        const irDiff = {
+                          diff_pct: parseFloat(irData.diffs.diff_pct),
+                          old: irData.metrics.Both[1].Int,
+                          new: irData.metrics.Both[0].Int
+                        };
                     hasResults = true;
                     const changePercentage = formatPercentage(irDiff.diff_pct);
                     const color = irDiff.diff_pct > 0 ? "red" : "lime";
@@ -178,19 +170,23 @@ jobs:
                     sectionBody += "<details>\n<summary>Detailed metrics</summary>\n\n```\n";
                     sectionBody += `Baselines:                master|       HEAD\n`;
 
-                    for (const [eventKind, costsDiff] of Object.entries(summary.events)) {
-                      if (costsDiff.diff_pct !== null) {
-                        const changePercentage = formatPercentage(costsDiff.diff_pct);
-                        const line = `${padRight(eventKind, 20)} ${padLeft(formatNumber(costsDiff.old), 11)}|${padLeft(formatNumber(costsDiff.new), 11)} ${padLeft(changePercentage, 15)}`;
+                    for (const [metricName, metricData] of Object.entries(part.metrics_summary.Callgrind)) {
+                      if (metricData.diffs && metricData.diffs.diff_pct !== null) {
+                        const changePercentage = formatPercentage(parseFloat(metricData.diffs.diff_pct));
+                        const oldValue = metricData.metrics.Both[1].Int || metricData.metrics.Both[1].Float;
+                        const newValue = metricData.metrics.Both[0].Int || metricData.metrics.Both[0].Float;
+                        const line = `${padRight(metricName, 20)} ${padLeft(formatNumber(Math.round(oldValue)), 11)}|${padLeft(formatNumber(Math.round(newValue)), 11)} ${padLeft(changePercentage, 15)}`;
                         sectionBody += `${line}\n`;
                       }
                     }
 
                     sectionBody += "```\n</details>\n\n";
 
-                    if (Math.abs(irDiff.diff_pct) > 5) {
-                      significantChanges = true;
-                      hasSignificantChanges = true;
+                        if (Math.abs(irDiff.diff_pct) > 5) {
+                          significantChanges = true;
+                          hasSignificantChanges = true;
+                        }
+                      }
                     }
                   }
                 }

.vscode/extensions.json

@@ -13,7 +13,6 @@
 		"streetsidesoftware.code-spell-checker",
 		// Helpful
 		"mhutchie.git-graph",
-		"waderyan.gitblame",
 		"qezhu.gitlink",
 		"wmaurer.change-case"
 	]