Simplify node graph type error diagnostic message text#3412
Closed
adamgerhant wants to merge 1 commit intomasterfrom
Closed
Simplify node graph type error diagnostic message text#3412adamgerhant wants to merge 1 commit intomasterfrom
adamgerhant wants to merge 1 commit intomasterfrom
Conversation
adamgerhant
force-pushed
the
improved-error-message
branch
from
0ef2336 to
c1436f6
Compare
adamgerhant
force-pushed
the
improved-error-message
branch
from
c1436f6 to
8376f2d
Compare
Keavon
changed the title
Keavon
changed the title
timon-schelling
force-pushed
the
master
branch
from
124235a to
a42cad8
Compare
Member
|
Closing this since I don't think it does what is directly needed, although I will aim to visit this in the future. I just need to design it first-hand, rather than attempt to review a proposed redesign. Thanks though 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old vs new
Potential further change: Hide error until clicked but show it on all erroring nodes. Not a single large error that jumps from node to node.
