Escape HTML in tooltips to prevent angle brackets being interpreted as tags#3524
Closed
Escape HTML in tooltips to prevent angle brackets being interpreted as tags#3524
Conversation
…kets Co-authored-by: Keavon <4388688+Keavon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix JS tooltips interpreting rust generics as HTML elements
Escape HTML in tooltips to prevent angle brackets being interpreted as tags
Dec 22, 2025
Keavon
requested changes
Dec 22, 2025
Member
Keavon
left a comment
There was a problem hiding this comment.
You should only have changed the one file.
Co-authored-by: Keavon <4388688+Keavon@users.noreply.github.com>
Author
Fixed in commit 8f9c354. The PR now only includes changes to Tooltip.svelte. |
Keavon
reviewed
Dec 22, 2025
| } | ||
|
|
||
| function escapeHtml(text: string): string { | ||
| return text.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">").replace(/"/g, """).replace(/'/g, "'"); |
Co-authored-by: Keavon <4388688+Keavon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tooltips containing Rust generic types like
Table<Vector<Option<Table<Graphic>>>>were being interpreted as HTML tags due to the{@html}directive inTooltip.svelte. The angle brackets caused the browser to attempt parsing them as elements, resulting in broken tooltip display.Changes
frontend/src/components/floating-menus/Tooltip.svelte:escapeHtml()function to escape<,>,&,",'charactersparseMarkdown()to escape HTML before applying markdown transformations (bold/italic/code)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.