Ignore out-of-range mouse button values using from_bits_truncate#3541
Merged
TrueDoctor merged 3 commits intoGraphiteEditor:masterfrom Jan 11, 2026
Merged
Conversation
Contributor
Author
|
Any updates on this ! |
Member
|
Not yet, still working to get caught up on PR reviews. Don't let this block you in other threads of work you're interested in, though! |
timon-schelling
force-pushed
the
master
branch
from
124235a to
a42cad8
Compare
TrueDoctor
approved these changes
Jan 11, 2026
Member
TrueDoctor
left a comment
TrueDoctor
left a comment
There was a problem hiding this comment.
Yeah, in the future it would be nice to be able to support these inputs, but until we have proper tablet support it is probably best to ignore the flags.
TrueDoctor
reviewed
Jan 11, 2026
TrueDoctor
force-pushed
the
fix/pen-tablet-eraser-mouse-buttons
branch
from
83d4acd to
fdde1a8
Compare
TrueDoctor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have'nt tested this locally since I don't have a tablet on me . But like 0HyperCube suggested, using the from_bits_truncate here . Don't see any other or better approach to this as well
Closes #3521