Skip to content

Fix math error affecting the linear segment -> polynomial logic #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrueDoctor merged 2 commits into from
Jan 2, 2026
Merged

Fix math error affecting the linear segment -> polynomial logic #3562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf6dadf
Fix typo in the linear segment -> polynomial code
0HyperCube Jan 1, 2026
1f67ea9
Merge branch 'master' into fix-typo-linear-polynomial
TrueDoctor Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node-graph/libraries/core-types/src/math/polynomial.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ impl<const N: usize> Mul for &Polynomial<N> {
pub fn pathseg_to_parametric_polynomial(segment: PathSeg) -> (Polynomial<4>, Polynomial<4>) {
match segment {
PathSeg::Line(line) => {
let term1 = line.p0 - line.p1;
let term1 = line.p1 - line.p0;
(Polynomial::new([line.p0.x, term1.x, 0., 0.]), Polynomial::new([line.p0.y, term1.y, 0., 0.]))
}
PathSeg::Quad(quad_bez) => {
Expand Down
14 changes: 14 additions & 0 deletions node-graph/libraries/vector-types/src/subpath/lookup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,17 @@ impl<PointId: Identifier> Subpath<PointId> {
.map(|(centroid_part, length)| (DVec2::new(centroid_part.x, centroid_part.y), length))
}
}

#[cfg(test)]
mod test_centroid {
use crate::vector::PointId;

use super::*;
#[test]
fn centroid_rect() {
let rect = Subpath::<PointId>::new_rect(DVec2::new(100., 100.), DVec2::new(300., 200.));
let (centre, area) = rect.area_centroid_and_area(Some(1e-3), Some(1e-3)).unwrap();
assert_eq!(area, 200. * 100.);
assert_eq!(centre, DVec2::new(200., 150.))
}
}
Loading