Skip to content

Desktop: Exclude node registry functions from desktop frontend builds #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrueDoctor merged 4 commits into from
Jan 6, 2026
Merged

Desktop: Exclude node registry functions from desktop frontend builds #3584

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05b36cb
Exclude node registry functions from desktop frontend builds
TrueDoctor Jan 6, 2026
e3dd798
Use early return
TrueDoctor Jan 6, 2026
46be42f
Fix branch name in build-linux pipeline
TrueDoctor Jan 6, 2026
8849824
Still generate native registration functions
TrueDoctor Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion frontend/wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ license = "Apache-2.0"
default = ["gpu", "shader-nodes"]
gpu = ["editor/gpu"]
shader-nodes = ["graphene-std/shader-nodes", "gpu"]
native = []
native = ["node-macro/disable-registration"]

[lib]
crate-type = ["cdylib", "rlib"]
Expand All @@ -39,6 +39,7 @@ wgpu = { workspace = true }
web-sys = { workspace = true }
ron = { workspace = true }
serde_json = { workspace = true }
node-macro = { workspace = true }

[package.metadata.wasm-pack.profile.dev]
wasm-opt = false
Expand Down
3 changes: 3 additions & 0 deletions node-graph/node-macro/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ license = "Apache-2.0"
[lib]
proc-macro = true

[features]
disable-registration = []

[dependencies]
# Workspace dependencies
syn = { workspace = true }
Expand Down
4 changes: 4 additions & 0 deletions node-graph/node-macro/src/codegen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,10 @@ fn generate_register_node_impl(parsed: &ParsedNodeFn, field_names: &[&Ident], st
}
let registry_name = format_ident!("__node_registry_{}_{}", NODE_ID.fetch_add(1, std::sync::atomic::Ordering::SeqCst), struct_name);

if cfg!(feature = "disable-registration") {
return Ok(quote!());
}

Ok(quote! {

#[cfg_attr(not(target_family = "wasm"), ctor)]
Expand Down
Loading