fix #3604 Apply Transform node produces the wrong result on shapes with handles#3617
Closed
chintu4 wants to merge 3 commits intoGraphiteEditor:masterfrom
Closed
fix #3604 Apply Transform node produces the wrong result on shapes with handles#3617chintu4 wants to merge 3 commits intoGraphiteEditor:masterfrom
chintu4 wants to merge 3 commits intoGraphiteEditor:masterfrom
Conversation
Member
|
!build |
|
Author
|
Is this pr got merged @timon-schelling |
Member
|
Thank you for your attempt at this, hopefully you learned from the process. I ended up with a simpler, one-line solution that I just merged in #3687 (feel free to take a look) that is preferable to the three-line + extraneous comments proposed in this PR. Please feel free to continue submitting PRs and they will each be considered, although this one didn't end up being the approach we went with. Thanks again for taking the time and learning along the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3604
The issue #3604 (Apply Transform node produces the wrong result on shapes with handles) i can see in the given video that
steps to reproduce issue.
fix
At "node-graph\nodes\vector\src\vector_modification_nodes.rs" file , apply_transform is function which is used internally in node-graph system this function shows no visible change after addition of control handler code in apply transform function.
I have added a 3 line in apply_tranform function so that tranformation from geometry to vector happen both on Achor and handlers. currently only anchor points are being handled .
the existing code only handles anchor points
Verification
I have compiled and run this project on Linux machine. I have saw that my change doesn't show any visible change in Artboard transformation happens internally. Iam getting feedback message that "The "node has no parameter" i expect this is a expected behaviour.
Here is the verification video
export_fix.mp4