Conversation
Keavon
approved these changes
Jan 16, 2026
Member
Keavon
left a comment
Keavon
left a comment
There was a problem hiding this comment.
Thanks for helping me finish the widgets and migration parts of this.
Keavon
changed the title
jackfruitdog
pushed a commit
to jackfruitdog/Graphite
that referenced
this pull request
Jan 25, 2026
…ng the value when unticked (GraphiteEditor#3643) * WIP * Fix widget * Fix migration * Remove OptionalF64 * Custom attributes for optional f64 widget * Code review * Move comments to another PR --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3587
Deprecates the
TaggedValue::OptionalF64by instead using a pair ofboolandf64input parameters, and adds a custom widget to display the checkbox and number inputs side-by-side.