Desktop: Restart without UI acceleration when it fails on Linux#3668
Desktop: Restart without UI acceleration when it fails on Linux#3668timon-schelling merged 2 commits intomasterfrom
Conversation
timon-schelling
force-pushed
the
desktop-linux-ui-fallback-restart
branch
from
375cda1 to
b3dc155
Compare
Keavon
changed the title
| let (cef_view_info_sender, cef_view_info_receiver) = std::sync::mpsc::channel(); | ||
|
|
||
| if cli.disable_ui_acceleration { | ||
| println!("UI acceleration is disabled"); |
There was a problem hiding this comment.
should this be an eprintln ?
There was a problem hiding this comment.
more of an info that an error, so in my opinion no.
but this will only stay for a couple of weeks anyways (until rc4).
There was a problem hiding this comment.
The question is more if it should be included if I pipe the output of graphite to a file, and I'd think it should probably not. E.g. the dbg! macro also outputs to stderr, and I would argue that is similar in nature
There was a problem hiding this comment.
Then we should also change the Available GPU lines?
I would merge this and we can decide later for all similar cases, currently most stuff ends up in stdout.
There was a problem hiding this comment.
yes, we should, from man stderr
Under normal circumstances every UNIX program has three streams opened for it when
it starts up, one for input, one for output, and one for printing diagnostic or
error messages.
timon-schelling
force-pushed
the
desktop-linux-ui-fallback-restart
branch
from
b3dc155 to
062c6d5
Compare
3 participants
Partly closes #3667