Add more javadoc for machine classes#4783
Merged
Merged
Conversation
gustovafing
changed the title
github-actions
Bot
added
Tests: Failed
github-actions
Bot
added
Tests: Passed
github-actions
Bot
added
Tests: Failed
gustovafing
force-pushed
the
gus/trait-priority
branch
from
a7f4620 to
45690e1
Compare
github-actions
Bot
added
Tests: Passed
github-actions
Bot
added
Tests: Failed
github-actions
Bot
added
Tests: Passed
jurrejelle
reviewed
Apr 18, 2026
Comment on lines
-105
to
-117
| @Override | ||
| public void onMachinePlaced(@Nullable LivingEntity player, ItemStack stack) { | ||
| super.onMachinePlaced(player, stack); | ||
| CompoundTag tag = stack.getTag(); | ||
| if (tag != null) { | ||
| if (tag.contains("taped") && tag.getBoolean("taped")) { | ||
| this.inventory.storage.deserializeNBT(tag.getCompound("inventory")); | ||
| } | ||
| setRenderState(getRenderState().setValue(GTMachineModelProperties.IS_TAPED, isTaped)); | ||
| syncDataHolder.markClientSyncFieldDirty("isTaped"); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
why was this (and the taped property) removed?
Member
Author
There was a problem hiding this comment.
The inventory key is only saved when the machine is broken while taped, therefore there is no reason to check for it when the crate is placed
jurrejelle
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.