Clean up facade cover rendering#4793
Merged
gustovafing merged 15 commits intoApr 28, 2026
Merged
Conversation
…same kind of clamping AE2 does to the facade quads
Contributor
Author
|
Don't merge this until I add back a few lines I forgot to cherrypick |
gustovafing
added
type: refactor
Member
|
Spotless |
# Conflicts: # src/main/java/com/gregtechceu/gtceu/client/renderer/cover/ICoverableRenderer.java
Contributor
Author
|
Done 👍 |
gustovafing
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clean up facade rendering & make do the same kind of clamping AE2 does to the facade quads (instead of just slapping the textures on a plane in front of the facade)
Implementation Details
Read code comments & commit names
Outcome
Nicer, better functioning facade rendering
How Was This Tested
NYT :3
Additional Information
I used AE2 as a reference for most of this. Should work the same it did before.
Potential Compatibility Issues
The cover back plate texture isn't the same as the wire side texture, so resource packs can replace that separately now. Shouldn't matter too much to most, but it might break someone's resource pack if they want those two to be the same texture.
To fix that, just copy the wire side texture to
gtceu:block/cover/cover_back_plate.