Simplify machine models#4800
Open
screret wants to merge 2 commits intoGregTechCEu:1.20.1from
Open
Conversation
…coalescing them into one Done primarily by ignoring the `is_formed` property on multiblock (part)s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Simplify machines' model JSONs by not specifying properties that do not affect the actual model in any way.
Implementation Details
Approximately 75 lines of code changed, most of which were to add a
, IS_FORMEDto most utility functions inGTMachineModels.The model parser assumes undefined properties to mean "any value". That's used to cut down 10 500 lines of JSON.
Outcome
Probably half a megabyte of final JAR file size saved.
How Was This Tested
The actual ingame models are the exact same before & after, as
Looked the same, I forgot to take screenshots.
Additional Information
Datagen produced ~450 file changes. I recommend ignoring those in the GitHub review UI before it tries to load all of them and your browser gives up.