Fix lamps' variations not working as advertised#4804
Merged
gustovafing merged 14 commits intoMay 1, 2026
Merged
Conversation
gustovafing
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed "no light" lamps just being turned off by default instead of emitting no block light, removed duplicates of vanilla block properties from GTBlockStateProperties and simplified the lamp blockstate jsons by ignoring unused1 properties
Outcome
GT Lamps work like they should now
How Was This Tested
Before:
This light will never be lit!
After:
Lamp with
lit=falsenot emitting light but still looking activeAdditional Information
Footnotes
The
lightproperty isn't actually used by the model, it disables actual light, the stuff that blocks mob spawns. ↩