Fix ToolHeadReplaceRecipe.matches() for non-existent material+tier combos#4809
Merged
gustovafing merged 1 commit intoApr 23, 2026
Conversation
gustovafing
approved these changes
Apr 23, 2026
Contributor
|
I think this fix might not work if the tool item is replaced via unification |
Contributor
Author
|
Not sure what unification is or what you mean by that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #4807
See #4807 for details
Outcome
Verifies
GTMaterialItems.TOOL_ITEMS.get(toolHead.material(), output[tool.getElectricTier()]) != nullbefore returningtruefrom matchesHow Was This Tested
Game runs, doesn't NPE when putting a wirecutter head and a wirecutter in the crafting grid where the wirecutter head material doesn't work with the wirecutter's tier