Remove material manager and merge addon material registries into single unified material registry#4816
Open
gustovafing wants to merge 10 commits into1.20.1from
Open
Remove material manager and merge addon material registries into single unified material registry#4816gustovafing wants to merge 10 commits into1.20.1from
gustovafing wants to merge 10 commits into1.20.1from
Conversation
gustovafing
added
type: refactor
TechLord22
reviewed
May 1, 2026
Comment on lines
+30
to
+36
| if (name.contains(":")) { | ||
| ResourceLocation resLoc = ResourceLocation.tryParse(name); | ||
| if (resLoc == null) return GTMaterials.NULL; | ||
| return get(resLoc); | ||
| } else { | ||
| return get(GTCEu.id(name)); | ||
| } |
Member
There was a problem hiding this comment.
How about:
ResourceLocation resLoc = ResourceLocation.tryParse(name);
if (resLoc == null) {
return get(GTCEu.id(name));
}
return get(resLoc);
Contributor
There was a problem hiding this comment.
that'll give minecraft:<name> for valid resource locations, which is. not ideal.
Contributor
There was a problem hiding this comment.
Also, doesn't GTCEu.java have a method named appendId that does exactly this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the material manager and associated classes.
Instead of having a
Registry<String, Material>for each addon, there is a single globalRegistry<ResourceLocation, Material>.Implementation Details
Any addon devs should remove their own material registry creation and just use the static
GTRegistries.MATERIALS.Addon/Modpack devs should rename any references to
GTCEuAPI.materialManagerwithGTRegistries.MATERIALS.