De-ldlib the prospector UI#4822
Open
screret wants to merge 15 commits intoGregTechCEu:mui2-refactorfrom
Open
Conversation
like, what?? wtf is that why would Kila do that
…them in some places and fetching the value early in others
Member
|
Untested PR, will remain on indefinite hold until testing data is appended |
Contributor
Author
|
@Ghostipedia testing's been done, could you remove the label? |
Member
|
hmm why are the multiblock_lcent_ranged tests all failing |
gustovafing
approved these changes
May 6, 2026
Member
gustovafing
left a comment
gustovafing
left a comment
There was a problem hiding this comment.
lgtm, will wait for another review before merging
gustovafing
added
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
title.
Implementation Details
mostly functions the same. I think (from looking at the code). no clue if it actually works or if I did it correctly. timrd.
Outcome
No more LDLib UIs
How Was This Tested
Uploading java_davYEc6CoM.mp4…
link in case that video never uploads
Additional Information
Most of the code (cleaning up the prospector stuff in general) is from here.
Potential Compatibility Issues
IDK, none that I know of.. but most of this code was written 1-2 months ago so I'm not really sure.
Please fill in as much useful information as possible. Also, please remove all unused sections, including this and the other explanations.