Skip to content

Fix the ore prospection radius config's minimum value #4825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurrejelle merged 2 commits into from
May 10, 2026
Merged

Fix the ore prospection radius config's minimum value #4825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
361d407
Fix the ore prospection radius config's minimum value
screret May 10, 2026
5ad05e2
add to changelist
screret May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/content/Modpacks/Changes/v8.0.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,5 @@ A large number of machine feature interfaces have been removed, and have had the
- `BlastingRecipeBuilder`, `CampfireRecipeBuilder`, `SmeltingRecipeBuilder` and `SmokingRecipeBuilder` have been merged into `SimpleCookingRecipeBuilder`
- Example usage: `SimpleCookingRecipeBuilder.campfireCooking("cooking_chicken").input(new ItemStack(Items.CHICKEN)).output(new ItemStacks(Items.COOKED_CHICKEN)).cookingTime(100).experience(100).save(provider);`
- `GTFluidImpl` has been merged into `GTFluid`, use `GTFluid.Flowing` and `GTFluid.Source` instead of `GTFluidImpl.Flowing` and `GTFluidImpl.Source`.
- Item behaviors have been moved to `common/item/behavior`, and some items have been moved from `api/item` to `common/item`.
- Item behaviors have been moved to `common/item/behavior`, and some items have been moved from `api/item` to `common/item`.
- Changed the minimum value of the `compat.minimap.surfaceRockProspectRange` and `compat.minimap.oreBlockProspectRange` configs from -1 to 0. The behavior is still disabled with 0.
8 changes: 4 additions & 4 deletions src/main/java/com/gregtechceu/gtceu/config/ConfigHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,13 @@ public static class MinimapCompatConfig {

@Configurable
@Configurable.Comment({ "The radius, in blocks, that picking up a surface rock will search for veins in.",
"-1 to disable.", "Default: 24" })
@Configurable.Range(min = 1)
"0 to disable.", "Default: 24" })
@Configurable.Range(min = 0)
public int surfaceRockProspectRange = 24;
@Configurable
@Configurable.Comment({ "The radius, in blocks, that clicking an ore block will search for veins in.",
"-1 to disable", "Default: 24" })
@Configurable.Range(min = 1)
"0 to disable", "Default: 24" })
@Configurable.Range(min = 0)
public int oreBlockProspectRange = 24;

@Configurable
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/gregtechceu/gtceu/integration/map/cache/server/ServerCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void prospectSurfaceRockMaterial(ResourceKey<Level> dim, Material materia

public void prospectBySurfaceRockMaterial(ResourceKey<Level> dim, final Material material, BlockPos pos,
ServerPlayer player, int radius) {
if (radius < 0) return;
if (radius <= 0) return;
List<GeneratedVeinMetadata> nearbyVeins = getNearbyVeins(dim, pos, radius);
List<GeneratedVeinMetadata> foundVeins = new ArrayList<>();
for (GeneratedVeinMetadata nearbyVein : nearbyVeins) {
Expand All @@ -87,7 +87,7 @@ public void prospectBySurfaceRockMaterial(ResourceKey<Level> dim, final Material

public void prospectByOreMaterial(ResourceKey<Level> dim, Material material, BlockPos origin, ServerPlayer player,
int radius) {
if (radius < 0) return;
if (radius <= 0) return;
List<GeneratedVeinMetadata> nearbyVeins = getNearbyVeins(dim, origin, radius);
List<GeneratedVeinMetadata> foundVeins = new ArrayList<>();
for (GeneratedVeinMetadata nearbyVein : nearbyVeins) {
Expand All @@ -100,7 +100,7 @@ public void prospectByOreMaterial(ResourceKey<Level> dim, Material material, Blo

public void prospectByDepositName(ResourceKey<Level> dim, String depositName, BlockPos origin, ServerPlayer player,
int radius) {
if (radius < 0) return;
if (radius <= 0) return;
List<GeneratedVeinMetadata> nearbyVeins = getNearbyVeins(dim, origin, radius);
List<GeneratedVeinMetadata> foundVeins = new ArrayList<>();
for (GeneratedVeinMetadata nearbyVein : nearbyVeins) {
Expand Down
Loading