RBA improvements#6595
Conversation
| } | ||
| } else if (itemOnCRight == ITEM_MASK_GERUDO || itemOnCRight == ITEM_MASK_TRUTH) { | ||
| HandleRBAPaddingBytes(); | ||
| HandleRBAPaddingBytes(itemToPutInBottle); |
There was a problem hiding this comment.
Should this have an IS_RANDO check?
| } | ||
| } else if (itemOnCRight == ITEM_SONG_NOCTURNE || itemOnCRight == ITEM_SONG_PRELUDE) { | ||
| HandleRBAPaddingBytes(); | ||
| HandleRBAPaddingBytes(itemToPutInBottle); |
There was a problem hiding this comment.
And here for the IS_RANDO check too
|
What's the reason for limiting RBA in rando? |
|
Just wondering, would it be possible to put the RANDO checks behind some other CVar toggle check? I know it's uncommon for anyone to want to use RBA in rando, but I feel like it wouldn't be clear to the user that this is the case |
|
Even if it would somehow be clear, I think this should be up to the player wether it should be limited or not, so a toggle feels much better than just checking for rando. |
|
My idea was that RBA will never be in logic due to it's nature of removing items under certain circumstances, the idea is that if RBA is a no-op in rando, that opens up the possibility of adding BA to logic in the future. |
|
We already have several things that are no-logic only, and RBA is pretty niche. I figure, if anyone ends up trying to do it in rando, they'd know what they were getting themselves into. |
|
Hm, I feel as though logic dictating the mechanics isn't the best approach, but instead it should be that the logic describes only what it can guarantee from the mechanics. Essentially, BA/RBA logic can exist as though BA/RBA is no-op but the user shouldn't be limited by such a thing |
|
RBA is very unlikely to be added to logic because of it's ability to destroy items, which is basically impossible to account for. for rando I would consider it a no-logic only glitch. |
|
splitting up padding / hook improvements might make sense. there's design discussion for rando handling https://youtu.be/SvAP9LYvsT4?t=1769 yesterday's hell seed by zfg involved equipswap over Farore's, we need to be careful on how we handle glitches in rando. at 34:00 there's some rba discussion that supports this, but there's a line between our hooks & a player's preferences overall I think this is the way to go, but maybe it needs to be setting |
6 participants
Implements RBA/BA using padding bytes as "storage".
In rando, limits RBA to padding & ammo (except bean).
General cleanup.
Build Artifacts