Use double-quoted string constants for type and race in level_penalty#3412
Merged
hemagx merged 1 commit intoHerculesWS:masterfrom Apr 22, 2026
Merged
Conversation
MrKeiKun
force-pushed
the
feat-level-penalty-string-constants
branch
from
1349dd3 to
4fa1888
Compare
MrKeiKun
force-pushed
the
feat-level-penalty-string-constants
branch
from
4fa1888 to
b638008
Compare
hemagx
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
The
typefield inlevel_penalty.confalready supported quoted string constants (e.g."EXP_PENALTY_RATE"), butracewas integer-only and both fields were written as bare unquoted identifiers in the conf file and the converter output.Issues addressed: