WIP Use score in tree hyperparameter notebook#503
Open
glemaitre wants to merge 1 commit intoINRIA:mainfrom
Open
WIP Use score in tree hyperparameter notebook#503glemaitre wants to merge 1 commit intoINRIA:mainfrom
glemaitre wants to merge 1 commit intoINRIA:mainfrom
Conversation
ogrisel
reviewed
Sep 1, 2023
Collaborator
ogrisel
left a comment
There was a problem hiding this comment.
I started to review this PR but I noticed that it requires blackification first.
Comment on lines
+128
to
+133
| accuracy = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | ||
|
|
||
| _ = plt.title( | ||
| f"Shallow regression tree with max-depth of {max_depth}" | ||
| f"\n R$^2$ of the fit: {accuracy:.2f}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| accuracy = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | |
| _ = plt.title( | |
| f"Shallow regression tree with max-depth of {max_depth}" | |
| f"\n R$^2$ of the fit: {accuracy:.2f}" | |
| ) | |
| r2 = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | |
| _ = plt.title( | |
| f"Shallow regression tree with max-depth of {max_depth}" | |
| f"\n R$^2$ of the fit: {r2:.2f}" | |
| ) |
Comment on lines
+159
to
+164
| accuracy = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | ||
|
|
||
| _ = plt.title( | ||
| f"Shallow regression tree with max-depth of {max_depth}" | ||
| f"\n R$^2$ of the fit: {accuracy:.2f}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| accuracy = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | |
| _ = plt.title( | |
| f"Shallow regression tree with max-depth of {max_depth}" | |
| f"\n R$^2$ of the fit: {accuracy:.2f}" | |
| ) | |
| r2 = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | |
| _ = plt.title( | |
| f"Shallow regression tree with max-depth of {max_depth}" | |
| f"\n R$^2$ of the fit: {r2:.2f}" | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR isolate the call to score in the hyperparameter notebook.
It is linked to the comment: #464 (comment)
In this PR, we should therefore address the concern of @ogrisel: