Add MKLMemory class to expose MKL allocated memory via Python buffer protocol#182
Open
ndgrigorian wants to merge 8 commits intouse-meson-buildfrom
Open
Add MKLMemory class to expose MKL allocated memory via Python buffer protocol#182ndgrigorian wants to merge 8 commits intouse-meson-buildfrom
MKLMemory class to expose MKL allocated memory via Python buffer protocol#182ndgrigorian wants to merge 8 commits intouse-meson-buildfrom
Conversation
exposes Python buffer protocol
ndgrigorian
force-pushed
the
feature/add-mkl-memory
branch
2 times, most recently
from
0071f09 to
c88863f
Compare
as atomics are a c11+ feature, specific flags are needed to enable on window
ndgrigorian
force-pushed
the
feature/add-mkl-memory
branch
from
c88863f to
d4cc27f
Compare
ndgrigorian
force-pushed
the
feature/add-mkl-memory
branch
from
32ec03b to
5909cac
Compare
ndgrigorian
force-pushed
the
feature/add-mkl-memory
branch
from
aed1ff6 to
a99e626
Compare
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes the introduction of
_mkl_memory.pyx, which implements anMKLMemoryclass that exposes memory allocated viamkl_mallocandmkl_callocto Python via the buffer protocolThe class uses an atomic counter incremented as
__getbuffer__and__releasebuffer__are called to track the views on the buffer to permit use ofmkl_reallocin the object (viareallocmethod). This concept was adapted from the PEP which revised the buffer protocol which proposed this kind of approach to tracking views on a bufferCloses #18