Fix singlejar issue#8
Open
Xytronix wants to merge 3 commits into
Open
Conversation
Xytronix
force-pushed
the
pre-release
branch
3 times, most recently
from
aa85d9a to
66ac236
Compare
- Auto-patch legacy YYYY.MM.DD-sha ServerVersion manifests on load - Strip whitespace from semver strings via @ModifyVariable - Catch legacy format in SemverRange.fromString, return wildcard - Use correct server version 0.5.0-pre.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an earlyplugin JAR also declares a
Mainclass in a singlejar,MixinPluginClassLoader.hyinit$prioritizeLocalModClasswas forcing a re-load of every classthrough the mod's
PluginClassLoader. BecauseHyinitClassLoaderhad already defined the same class, this produced two copies with separate static state.My change skips the prioritization for singlejars so the OrbisGuard earlyplugin still gets their classes prioritized, but singlejars don't get duplicated.
Hytale dependency bumped to latest pre-release
2026.04.30-b4f6a911eand the project version to0.1.4.Type of change
Implementation details
src/main/java/cc/irori/hyinit/mixin/impl/MixinPluginClassLoader.javaextend the existing OrbisGuard-compat condition frommeta.isEarlyPlugin()tometa.isEarlyPlugin() && !meta.hasMainClass().Checklist
spotlessApplywhen necessary)