SDK-325 BCIT Migrate temp domain setup to final custom domain#1062
Draft
joaodordio wants to merge 1 commit into
Draft
SDK-325 BCIT Migrate temp domain setup to final custom domain#1062joaodordio wants to merge 1 commit into
joaodordio wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
- Coverage 71.03% 70.97% -0.06%
==========================================
Files 112 112
Lines 9238 9238
==========================================
- Hits 6562 6557 -5
- Misses 2676 2681 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
Migrating the BCIT integration tests off the temporary
tsetester.comdomain and onto the official engineering-ownedbcittesting.com(procured via IT-4410).What changed
iterablesdk-integration-tester.entitlements: associated domainapplinks:links.tsetester.com->applinks:links.bcittesting.comAppDelegate.swift: URL host checks and log strings now referencebcittesting.com/links.bcittesting.comUpdateViewController.swift: comment and on-screen flow info text updatedDeepLinkingIntegrationTests.swift: all test URL constants point at the new domain. The two wrapped click URLs are stubbed with aTODO_REGENERATE_TOKENplaceholder and aTODO(SDK-325)comment, since the_t/_m/_etokens are tied to the old Iterable project.Why the wrapped URL is a placeholder
The wrapped link tokens are project-scoped, so they will only become valid once SDK-36 #1061 lands and we can regenerate the link against the new project. I left a loud
TODO_REGENERATE_TOKENso any test run that uses it fails fast with a 404 instead of silently passing or hitting the old project.Dependencies / sequencing
This PR is intentionally not ready to merge yet. The order is:
links.bcittesting.comresolves and serves AASATODO_REGENERATE_TOKENin this PR, then merge