feat: ✨ integrate chat API#13
Merged
Merged
Conversation
numeru
approved these changes
May 16, 2026
| const room = chatRoomDetail; | ||
| const isEnded = room.status === "ended"; | ||
| const params = useParams({ strict: false }); | ||
| const voteId = Number(params.voteId); |
Collaborator
There was a problem hiding this comment.
params.chatRoomId 가 아닌지 확인 부탁드립니다!
Suggested change
| const voteId = Number(params.voteId); | |
| const voteId = Number(params.chatRoomId); |
Collaborator
Author
There was a problem hiding this comment.
꼼꼼한 리뷰 감사합니다! 확인해 보니 라우터 설정 파일명(chat.$chatRoomId.tsx)에 정의된 대로 chatRoomId를 사용하는 것이 맞네요. 바로 수정해서 추가 커밋 올리겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇을 변경했나요?
GET /api/chats?status=ONGOING | ENDEDAPI 연동을 추가했습니다.ONGOING,ENDED로 정리했습니다.GET /api/chats/{voteId}GET /api/chats/{voteId}/gaugeGET /api/chats/{voteId}/messagesPOST /api/chats/{voteId}/messagesendAt,lastMessageAt,sentAt기준으로 남은 시간과 시간 라벨을 표시하는 유틸 함수를 추가했습니다.왜 변경했나요?
어떻게 테스트했나요?
pnpm build확인 예정스크린샷 (UI 변경 시)
체크리스트
pnpm build)console.log제거