Skip to content

Tests: make assertions platform-neutral #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meiranzheng wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −16
Open

Tests: make assertions platform-neutral #2376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/CsvHelper.Tests/Mappings/ConstructorParameter/CultureInfoAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ private class NoAttribute
public decimal Amount { get; set; }
}

[CultureInfo("invalid")]
[CultureInfo("invalid!")]
private class InvalidAttribute
{
[CultureInfo("fr-FR")]
Expand Down
18 changes: 6 additions & 12 deletions tests/CsvHelper.Tests/TypeConversion/TypeConverterFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,11 @@ public void ReadTypeConverterGenericInt()
[Fact]
public void WriteTypeConverterGenericInt()
{
var expected = """
MaybeNumber
42

""";

var stringWriter = new StringWriter();
using var cw = new CsvWriter(stringWriter, CultureInfo.InvariantCulture);
var expected = new TestStringBuilder(cw.Configuration.NewLine);
expected.AppendLine("MaybeNumber");
expected.AppendLine("42");
cw.Context.TypeConverterCache.AddConverter(new MyOptionTypeFactory.OptionConverter<int>());
cw.WriteRecords(new[]
{
Expand All @@ -68,14 +65,11 @@ public void ReadTypeConverterFactory()
[Fact]
public void WriteTypeConverterFactory()
{
var expected = """
MaybeNumber
42

""";

var stringWriter = new StringWriter();
using var cw = new CsvWriter(stringWriter, CultureInfo.InvariantCulture);
var expected = new TestStringBuilder(cw.Configuration.NewLine);
expected.AppendLine("MaybeNumber");
expected.AppendLine("42");
cw.Context.TypeConverterCache.AddConverterFactory(new MyOptionTypeFactory());
cw.WriteRecords(new[]
{
Expand Down
9 changes: 6 additions & 3 deletions tests/CsvHelper.Tests/Writing/MultipleFieldsFromOnePropertyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,26 @@ public class MultipleFieldsFromOnePropertyTests
[Fact]
public void WriteMultipleFieldsFromSinglePropertyTest()
{
var culture = new CultureInfo("en-US");

using (var stream = new MemoryStream())
using (var reader = new StreamReader(stream))
using (var writer = new StreamWriter(stream))
using (var csv = new CsvWriter(writer, new CultureInfo("en-US")))
using (var csv = new CsvWriter(writer, culture))
{
var records = new List<Test>
{
new Test { Dob = DateTime.Parse("9/6/2017", new CultureInfo("en-US")) }
new Test { Dob = DateTime.Parse("9/6/2017", culture) }
};
csv.Context.RegisterClassMap<TestMap>();
csv.WriteRecords(records);
writer.Flush();
stream.Position = 0;

var dobText = records[0].Dob.ToString(culture);
var expected = new TestStringBuilder(csv.Configuration.NewLine);
expected.AppendLine("A,B,C");
expected.AppendLine("9/6/2017 12:00:00 AM,9/6/2017 12:00:00 AM,9/6/2017 12:00:00 AM");
expected.AppendLine($"{dobText},{dobText},{dobText}");

Assert.Equal(expected.ToString(), reader.ReadToEnd());
}
Expand Down