Minor cleanup on swapchain creation

[asuessenbach]

Essentially, introduced a little helper function to determine the minImageCount for the swapchain, and added some assertions.

As usual, if you think, this looks good, I can carry it over to the other chapters.

And still I'm not able to build or run this program, see #93.

[asuessenbach]

Any opinion on this PR?

[gpx1000]

Sorry, yep this looks good to me.

[asuessenbach]

This PR takes a number of iterations, as I still can't build on my own!

I still have the problem, that
>cmake -B build -S . -DCMAKE_TOOLCHAIN_FILE=C:\git\vcpkg\scripts\buildsystems\vcpkg.cmake
gives me

CMake Error at C:/Program Files/CMake/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find KTX (missing: KTX_INCLUDE_DIR KTX_LIBRARY)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  CMake/FindKTX.cmake:55 (find_package_handle_standard_args)
  C:/git/vcpkg/scripts/buildsystems/vcpkg.cmake:896 (_find_package)
  CMakeLists.txt:15 (find_package)

Any idea on how to resolve that is very much appreciated!

[SaschaWillems]

CMake setup seems to be flaky on Windows. Maybe you can manually specify KTX_INCLUDE_DIR and KTX_LIBRARY either at command line or via CMake GUI:

[SaschaWillems]

Changes LGTM and work fine for me on Windows 11.

[asuessenbach]

Maybe you can manually specify KTX_INCLUDE_DIR and KTX_LIBRARY either at command line or via CMake GUI

Yes, that works. Thanks for that hint.

Now everything builds fine. Besides lots of warnings like:
warning MSB8065: Custom build for item "C:\git\Vulkan-Tutorial\attachments\build\VS2022_64\CMakeFiles\aba807fc7232e5502cfd42ef82d295e2\shaders.rule" succeeded, but specified output "c:\git\vulkan-tutorial\attachments\build\vs2022_64\33_vulkan_profiles\shaders" has not been created. This may cause incremental build to work incorrectly.
Is that something I should be worried about?

Besides that, is there a way to start all attachments one after the other and close them automatically? Similar to the batch mode in Vulkan-Samples?

[asuessenbach]

... and: starting with 09_shader_modules, there are three projects per chapter in the VS solution: $chapter, $chapter_shader, and $chapter_slang_shader. Is that intended?

[gpx1000]

Yeah, that's sadly the way Visual Studio handles cmake. We can do things to organize it a bit; maybe can consolidate into one shader compile step, but that's just Visual Studio doing Visual Studio things.