Remove explicit CMake version requirement#149
Merged
SaschaWillems merged 2 commits intomainfrom Oct 1, 2025
Merged
Conversation
gpx1000
approved these changes
Aug 21, 2025
Collaborator
Author
|
CI oddly fails. For whatever reason it tries to use CMake 3.22.1. |
Contributor
|
Maybe try replacing the version = '4.02+' The + used to allow gradle to select any newer version. I think that's frowned upon as a practice; but it might still work? |
Removing the requirement does not work with CI
Collaborator
Author
|
That's what I did. That fixed the CI, and works fine for me using a more recent version (that 4.0.2) 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the explicit CMake version requirement for Android builds. It was pinned at 4.02, so everyone with a different version would see an error that CMake 4.0.2 could not be found. Even if you have a newer version installed.
Having that explicit requirement pinned to a single version is not necessary and as far as I can tell is safe to remove.
This PR makes it a min. requirement instead.