Fixed code snippet in Update 00_Base_code.adoc#161
Closed
rapfamily4 wants to merge 1 commit intoKhronosGroup:mainfrom
Closed
Fixed code snippet in Update 00_Base_code.adoc#161rapfamily4 wants to merge 1 commit intoKhronosGroup:mainfrom
rapfamily4 wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
There was an example Update 00_Base_code.adoc that wouldn't compile.
Collaborator
|
The fix is fine, but this code is not used anywhere in the tutorial's code. Might be better to remove or adjust to what is actually used in code. Any thoughts @gpx1000 ? |
Contributor
|
Yeah, should try to update it to what the code does. |
Collaborator
|
Will be addressed by #226 226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an example in Update 00_Base_code.adoc that wouldn't compile.