Use vk::StructureChain on pipeline creation.#178
Merged
marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom Oct 20, 2025
Merged
Use vk::StructureChain on pipeline creation.#178marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom
marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom
Conversation
SaschaWillems
approved these changes
Oct 1, 2025
Collaborator
SaschaWillems
left a comment
SaschaWillems
left a comment
There was a problem hiding this comment.
This improves readability by a lot!
So yes, I'm for doing it like this in all subsequent chapters.
Contributor
Author
|
Especially have a look at chapters 32 and 33, which need some special handling on the vk::StructureChain. Note that some chapters have errors both with and without this PR:
|
Collaborator
|
The issues with 35, 36 are prob. related to vcpkg. They work fine for me, but getting those to work on Windows was quite a hassle :/ |
Collaborator
Last time I checked pretty much all chapters had validation errors, we need to tackle these, see #134 |
gpx1000
approved these changes
Oct 10, 2025
SaschaWillems
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In chapter 12 and following, a structure chain is manually created on creating the pipeline.
Should we change that to using a vk::StructureChain, instead?