Update overview section#198
Merged
marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom Nov 17, 2025
Merged
Conversation
SaschaWillems
requested changes
Nov 13, 2025
Collaborator
SaschaWillems
left a comment
SaschaWillems
left a comment
There was a problem hiding this comment.
Looking goo. Only a few minor remarks from my side.
| * Create a VkInstance | ||
| * Select a supported graphics card (VkPhysicalDevice) | ||
| * Create a VkDevice and VkQueue for drawing and presentation | ||
| * Create a vk::Instance |
Collaborator
There was a problem hiding this comment.
Would remove the vk:: completely. So e.g. just "Create a device and a queue for...".
| could be used to implement your own window manager, for example. | ||
|
|
||
| === Step 4 - Image views and framebuffers | ||
| === Step 4 - Image views and Dynamic Rendering |
Collaborator
There was a problem hiding this comment.
Would move all the dynamic rendering stuff to Step 5.
Contributor
Author
|
@SaschaWillems Thanks for the review |
SaschaWillems
approved these changes
Nov 15, 2025
gpx1000
approved these changes
Nov 15, 2025
Contributor
gpx1000
left a comment
gpx1000
left a comment
There was a problem hiding this comment.
Thanks for the edits! This looks great to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the tutorial to reflect the changes introduced by
dynamic renderingin Vulkan 1.3 and modern C++-style Vulkan API usage. The goal is to remove confusion from the original approach and simplify the workflow for rendering operations, addressing both issue #168 and issue #190.EDIT: Well maybe I should have used the RAII functionality like you do in the tutorial..
@gpx1000 Would be happy if you could review this and leave some feedback for improvements!