Skip to content

Comment usage of waitIdle in chapter 15 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpx1000 merged 2 commits into from
Oct 30, 2025
Merged

Comment usage of waitIdle in chapter 15 #207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41bb083
Reduce usage of waitIdle in 15_hello_triangle
asuessenbach Oct 22, 2025
6a4c0cc
Revert changes in drawFrame, add some comment to waitIdle
asuessenbach Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions attachments/15_hello_triangle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ class HelloTriangleApplication {
glfwPollEvents();
drawFrame();
}

device.waitIdle();
device.waitIdle(); // wait for device to finish operations before destroying resources
}

void cleanup() {
Expand Down Expand Up @@ -456,7 +455,8 @@ class HelloTriangleApplication {
}

void drawFrame() {
queue.waitIdle();
queue.waitIdle(); // NOTE: for simplicity, wait for the queue to be idle before starting the frame
// In the next chapter you see how to use multiple frames in flight and fences to sync

auto [result, imageIndex] = swapChain.acquireNextImage( UINT64_MAX, *presentCompleteSemaphore, nullptr );
recordCommandBuffer(imageIndex);
Expand Down
Loading