Fix synchronization#211
Merged
marty-johnson59 merged 6 commits intomainfrom Nov 3, 2025
Merged
Conversation
Except for chapter 33, which doesn't seem to be easil fixable
Use functions similar to other chapters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the synchronization issues with all chapters starting with hello triangle. For chapters that use depth buffering, it also fixes sync issues related to depth.
I also tried to at least somewhat clean up how image layout transitions are issued by removing duplicate functions.
Note: This PR doesn't change much in regards to the documentation. That's because it often heavily diverges from the code and would require partially big reworks (e.g. in the depth buffering chapter).
Refs #153
Fixes #134