Skip to content

Update 03_Physical_devices_and_queue_families.adoc #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marty-johnson59 merged 1 commit into from
Nov 3, 2025
Merged

Update 03_Physical_devices_and_queue_families.adoc #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions en/03_Drawing_a_triangle/00_Setup/03_Physical_devices_and_queue_families.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ add to that function.
[,c++]
----
for (const auto& device : devices) {
physicalDevice = std::make_unique<vk::raii::PhysicalDevice>(device);
physicalDevice = device;
break;
}
----
Expand Down Expand Up @@ -93,14 +93,15 @@ function would look like this:

[,c++]
----
bool isDeviceSuitable(VkPhysicalDevice device) {
auto deviceProperties = device.getProperties();
auto deviceFeatures = device.getFeatures();
if (deviceProperties.deviceType == vk::PhysicalDeviceType::eDiscreteGpu &&
deviceFeatures.geometryShader) {
physicalDevice = std::make_unique<vk::raii::PhysicalDevice>(device);
break;
}
bool isDeviceSuitable(vk::raii::PhysicalDevice physicalDevice) {
auto deviceProperties = physicalDevice.getProperties();
auto deviceFeatures = physicalDevice.getFeatures();

if (deviceProperties.deviceType == vk::PhysicalDeviceType::eDiscreteGpu && deviceFeatures.geometryShader) {
return true;
}

return false;
}
----

Expand All @@ -117,7 +118,7 @@ something like that as follows:
...

void pickPhysicalDevice() {
auto devices = vk::raii::PhysicalDevices( *instance );
auto devices = vk::raii::PhysicalDevices( instance );
if (devices.empty()) {
throw std::runtime_error( "failed to find GPUs with Vulkan support!" );
}
Expand Down Expand Up @@ -146,7 +147,7 @@ void pickPhysicalDevice() {

// Check if the best candidate is suitable at all
if (candidates.rbegin()->first > 0) {
physicalDevice = std::make_unique<vk::raii::PhysicalDevice>(candidates.rbegin()->second);
physicalDevice = candidates.rbegin()->second;
} else {
throw std::runtime_error("failed to find a suitable GPU!");
}
Expand Down Expand Up @@ -218,9 +219,9 @@ could look like this:

[,c++]
----
uint32_t findQueueFamilies(VkPhysicalDevice device) {
uint32_t findQueueFamilies(vk::raii::PhysicalDevice physicalDevice) {
// find the index of the first queue family that supports graphics
std::vector<vk::QueueFamilyProperties> queueFamilyProperties = physicalDevice->getQueueFamilyProperties();
std::vector<vk::QueueFamilyProperties> queueFamilyProperties = physicalDevice.getQueueFamilyProperties();

// get the first index into queueFamilyProperties which supports graphics
auto graphicsQueueFamilyProperty =
Expand Down
Loading