Skip to content

Fix vector size for presentCompleteSemaphores.#219

Merged
gpx1000 merged 4 commits intoKhronosGroup:mainfrom
asuessenbach:16_frames_in_flight
Dec 5, 2025
Merged

Fix vector size for presentCompleteSemaphores.#219
gpx1000 merged 4 commits intoKhronosGroup:mainfrom
asuessenbach:16_frames_in_flight

Conversation

@asuessenbach
Copy link
Copy Markdown
Contributor

@asuessenbach asuessenbach commented Nov 5, 2025

Only the semaphores signalled on finished rendering need to be indexed by the image index. All other resources (command buffers, fences, semaphores signalled on present completion) are indexed by the frame index.

Includes some minor clean-up on chapter 15 as well.

As usual, if this is considered to be ok, I can carry this change to all the other chapters.

@asuessenbach asuessenbach changed the title Fix vector sizes for presentCompleteSemaphores in chapter 16. Fix vector size for presentCompleteSemaphores in chapter 16. Nov 5, 2025
@SaschaWillems
Copy link
Copy Markdown
Collaborator

As usual, if this is considered to be ok, I can carry this change to all the other chapters.

Definitively yes.

Without this change, the tutorial is not spec compliant, see #65

@asuessenbach asuessenbach force-pushed the 16_frames_in_flight branch 2 times, most recently from 0faa53f to 9a803ea Compare November 10, 2025 12:16
@asuessenbach asuessenbach changed the title Fix vector size for presentCompleteSemaphores in chapter 16. Fix vector size for presentCompleteSemaphores. Nov 10, 2025
Copy link
Copy Markdown
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, but tutorial text needs to be adjusted to. Did a quick compare of the frames in flight chapter, and it no longer matches the semaphore setup now used in code.

@asuessenbach
Copy link
Copy Markdown
Contributor Author

but tutorial text needs to be adjusted to

If you could give me a hint, where the corresponding tutorial text is, I could try to adjust it accordingly.

@SaschaWillems
Copy link
Copy Markdown
Collaborator

E.g. "03_Frames_in_flight.adoc". Looking at this, it does at least partially differ from the updated code and might need to be updated.

@asuessenbach
Copy link
Copy Markdown
Contributor Author

@SaschaWillems Ok, I've adjusted some documentation. Please have a closer look at it!

@asuessenbach asuessenbach force-pushed the 16_frames_in_flight branch 2 times, most recently from 7e93cd5 to 94768d7 Compare November 27, 2025 18:51
@asuessenbach
Copy link
Copy Markdown
Contributor Author

Anything else I'd need to adjust?

@gpx1000 gpx1000 merged commit 70c62f0 into KhronosGroup:main Dec 5, 2025
6 checks passed
@asuessenbach asuessenbach deleted the 16_frames_in_flight branch December 8, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants