Add depth buffering to chapter 34#223
Merged
marty-johnson59 merged 3 commits intomainfrom Dec 11, 2025
Merged
Conversation
Clean up and make code more consistent with the rest of the tutorial
gpx1000
approved these changes
Dec 3, 2025
Contributor
|
Merging w/ Steve's approval (per decision on previous call) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds proper depth buffering to chapter 34. Without this fix, the model isn't rendered properly.
I also made parts of the code match the rest of the tutorial, esp. stuff regarding image creation (which differed from the way other chapters do it).
None of the code touched by this is mentioned in the tutorial text, so no need to update the text for the chapter.
Fixes #164