Fix the mipmap lesson: maxLod must be set in SamplerCreateInfo in order for mipmaps to work#234
Merged
marty-johnson59 merged 1 commit intoKhronosGroup:mainfrom Dec 1, 2025
slavc:fix_mipmap_lesson
Merged
Fix the mipmap lesson: maxLod must be set in SamplerCreateInfo in order for mipmaps to work#234marty-johnson59 merged 1 commit intoKhronosGroup:mainfrom slavc:fix_mipmap_lesson
marty-johnson59 merged 1 commit intoKhronosGroup:mainfrom
slavc:fix_mipmap_lesson
Conversation
…er for mipmaps to work Fix .maxLod not being set in the SamplerCreateInfo, which leads to it being initialized to zero, which leads to mip mapping effectively being disabled with only the zeroth mip level being used.
Contributor
Author
|
Relevant Vulkan specification documentation: https://docs.vulkan.org/spec/latest/chapters/samplers.html#VkSamplerCreateInfo . |
Collaborator
|
That's an embarrassing oversight. Thanks for fixing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix .maxLod not being set in the SamplerCreateInfo, which leads to it being initialized to zero, which leads to mip mapping effectively being disabled with only the zeroth mip level being used.