Fix waitForFences usage and documentation#246
Merged
SaschaWillems merged 3 commits intomainfrom Dec 16, 2025
Merged
Conversation
Properly check return value and throw on error Fix Rendering and presentation chapter paragraph Adjust documentation for multi threading chapter to actuall match code
Collaborator
Author
|
@gpx1000: What should we do with mixing of C++ and C-Syntax? When fixing documentation, or adding stuff, I try to stay as close to the code as possible and use C++-Syntax in the documentation. That leads to a not-so-nice mix of vulkan-hpp and vulkan-h terms and names in some of the chapters. Shouldn't we just update all of them to vulkan-hpp instead? |
asuessenbach
reviewed
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the odd loop-formatting used for fence waits. It replaces it with proper result code checking, which the tutorial didn't do before. So timeouts for fences are now properly handled.
Also fixes several documentation related issues, like a errors and code differences in the presentation chapter and the code in the multi threading chapter not matching the actual code.
Refs #121
Fixes #124
Fixes #244