Skip to content

Fixed old glsl local_ prefix in the compute shader tutorial and fixed 404 links #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpx1000 merged 3 commits into from
Jul 15, 2025
Merged

Fixed old glsl local_ prefix in the compute shader tutorial and fixed 404 links #96

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c18195
Fixed old glsl `local_` prefix in the compute shader tutorial.
wpsimon09 Jul 12, 2025
860bb38
fixed links on the compute shader page (tested locally)
wpsimon09 Jul 13, 2025
80a1524
Merge branch 'KhronosGroup:main' into patch-1
wpsimon09 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions en/11_Compute_Shader.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ outputImage[int2(gl_GlobalInvocationID.xy)] = pixel;

== Compute queue families

In the link:03_Drawing_a_triangle/00_Setup/03_Physical_devices_and_queue_families.adoc[physical device and queue families chapter],
In the xref:03_Drawing_a_triangle/00_Setup/03_Physical_devices_and_queue_families.adoc[physical device and queue families chapter],
we have already learned about queue families and how to select a graphics queue family.
Compute uses the queue family properties flag bit `vk::QueueFlagBits::eCompute`.
So if we want to do compute work, we need to get a queue from a queue family that supports compute.
Expand Down Expand Up @@ -518,8 +518,7 @@ An interesting thing is this compute-only declaration related to the compute spa

This defines the number of invocations of this compute shader in the current work group.
As noted earlier, this is the local part of the compute space.
Hence, the `local_` prefix.
As we work on a linear 1D array of particles, we only need to specify a number for x dimension in `local_size_x`.
As we work on a linear 1D array of particles, we only need to specify a number for x dimension in `[numthreads(x,y,z)]`.

The `compMain` function then reads from the last frame's SSBO and writes the
updated particle position to the SSBO for the current frame.
Expand Down Expand Up @@ -590,8 +589,8 @@ Wrong or lacking synchronization may result in the vertex stage starting to draw
So we must make sure that those cases don't happen by properly synchronizing the graphics and the compute load.
There are different ways of doing so, depending on how you submit your
compute workload, but in our case with two separate submits, we'll be using
link:03_Drawing_a_triangle/03_Drawing/02_Rendering_and_presentation.adoc[semaphores] and
link:03_Drawing_a_triangle/03_Drawing/02_Rendering_and_presentation.adoc[fences] to ensure that the vertex shader won't start fetching
xref:03_Drawing_a_triangle/03_Drawing/02_Rendering_and_presentation.adoc[semaphores] and
xref:03_Drawing_a_triangle/03_Drawing/02_Rendering_and_presentation.adoc[fences] to ensure that the vertex shader won't start fetching
vertices until the compute shader has finished updating them.

This is necessary as even though the two submits are ordered one-after-another, there is no guarantee that they execute on the GPU in this order.
Expand All @@ -601,7 +600,7 @@ So we first add a new set of synchronization primitives for the compute work in
The compute fences, just like the graphics fences, are created in the
signaled state because otherwise, the first draw would time out while waiting
for the fences to be signaled as detailed
link:03_Drawing_a_triangle/03_Drawing/02_Rendering_and_presentation.adoc[here]:
xref:03_Drawing_a_triangle/03_Drawing/02_Rendering_and_presentation.adoc[here]:

[,c++]
----
Expand Down Expand Up @@ -651,7 +650,7 @@ We then use these to synchronize the compute buffer submission with the graphics
----

Similar to the sample in the
link:03_Drawing_a_triangle/03_Drawing/02_Rendering_and_presentation.adoc[semaphore chapter], this setup will immediately run the
xref:03_Drawing_a_triangle/03_Drawing/02_Rendering_and_presentation.adoc[semaphore chapter], this setup will immediately run the
compute shader as we haven't specified any wait semaphores.
Note that we're using scoping braces above to ensure that the RAII temporary
variables we use get a chance to clean themselves up between the compute and
Expand Down
Loading