Skip to content

Avoid checks that will never be satisfied (Strings vs enums)#1132

Merged
labkey-jeckels merged 1 commit into
developfrom
fb_stringVsEnum
May 13, 2026
Merged

Avoid checks that will never be satisfied (Strings vs enums)#1132
labkey-jeckels merged 1 commit into
developfrom
fb_stringVsEnum

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

Rationale

These if() statements will never evaluate true as they're comparing Strings and enums for equality. It's been that way since at least 2013.

Changes

  • Delete the effectively dead code

@labkey-jeckels labkey-jeckels self-assigned this May 12, 2026
@bbimber
Copy link
Copy Markdown
Collaborator

bbimber commented May 12, 2026

hi @labkey-jeckels, yes i actually noticed this when i was reviewing your other PR. do you know if this import method is actually in use anymore? To my knowledge WNPRC is the only center that would have used this, and I thought that instrument was no longer in use.

@labkey-jeckels
Copy link
Copy Markdown
Contributor Author

hi @labkey-jeckels, yes i actually noticed this when i was reviewing your other PR. do you know if this import method is actually in use anymore? To my knowledge WNPRC is the only center that would have used this, and I thought that instrument was no longer in use.

I don't know. @labkey-mohara, if you have a chance to ask WNPRC on the next call, we may be able to complete delete this class. The type used should be captured as a batch property (hidden by default) for Viral Load assay types. The one in question would show up as ABI 7500

@labkey-jeckels labkey-jeckels merged commit 7d572ff into develop May 13, 2026
8 of 9 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_stringVsEnum branch May 13, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants