Avoid checks that will never be satisfied (Strings vs enums)#1132
Conversation
|
hi @labkey-jeckels, yes i actually noticed this when i was reviewing your other PR. do you know if this import method is actually in use anymore? To my knowledge WNPRC is the only center that would have used this, and I thought that instrument was no longer in use. |
I don't know. @labkey-mohara, if you have a chance to ask WNPRC on the next call, we may be able to complete delete this class. The type used should be captured as a batch property (hidden by default) for Viral Load assay types. The one in question would show up as |
Rationale
These if() statements will never evaluate true as they're comparing Strings and enums for equality. It's been that way since at least 2013.
Changes