Remove GWT framework by labkey-jeckels · Pull Request #7659 · LabKey/platform

labkey-jeckels · 2026-05-08T21:34:35Z

Rationale

We've migrated all of our GWT apps to React. We can now remove GWT itself.

Changes

Remove GWT as a dependency
Remove GWT UI code
Remove GWT services and actions
Simplify configuration for Jackson serialization of key data transfer classes (which retain the "GWT" prefix for now)

Tasks 📍

Claude Code Review
~~Manual Testing~~
~~Test Automation~~

# Conflicts: # assay/package-lock.json # assay/package.json # assay/src/client/PlateTemplateDesigner/PlateTemplateDesigner.scss # assay/src/client/PlateTemplateDesigner/PlateTemplateDesigner.test.tsx # assay/src/client/PlateTemplateDesigner/PlateTemplateDesigner.tsx # assay/src/client/PlateTemplateDesigner/PlateTemplateDesigner.utils.test.ts # assay/src/client/PlateTemplateDesigner/components/GroupTypesPanel.test.tsx # assay/src/client/PlateTemplateDesigner/components/GroupTypesPanel.tsx # assay/src/client/PlateTemplateDesigner/components/MultiCreateDialog.test.tsx # assay/src/client/PlateTemplateDesigner/components/MultiCreateDialog.tsx # assay/src/client/PlateTemplateDesigner/components/RightPanel.tsx # assay/src/client/PlateTemplateDesigner/components/ShiftPanel.test.tsx # assay/src/client/PlateTemplateDesigner/components/ShiftPanel.tsx # assay/src/client/PlateTemplateDesigner/components/StatusBar.test.tsx # assay/src/client/PlateTemplateDesigner/components/StatusBar.tsx # assay/src/client/PlateTemplateDesigner/components/TabButton.tsx # assay/src/client/PlateTemplateDesigner/components/TemplateGrid.test.tsx # assay/src/client/PlateTemplateDesigner/components/TemplateGrid.tsx # assay/src/client/PlateTemplateDesigner/components/WarningPanel.tsx # assay/src/client/PlateTemplateDesigner/components/WellGroupProperties.test.tsx # assay/src/client/PlateTemplateDesigner/components/WellGroupProperties.tsx # assay/src/client/PlateTemplateDesigner/models.test.ts # assay/src/client/PlateTemplateDesigner/models.ts # assay/src/client/entryPoints.js # assay/src/org/labkey/assay/PlateController.java # assay/src/org/labkey/assay/plate/PlateDataServiceImpl.java # assay/test/js/setup.ts

labkey-jeckels · 2026-05-08T22:52:55Z

I plan to rename the classes/packages in a followup commit. That'll touch more repos.

labkey-adam

One case that should be converted to Objects.equals(). If straightforward, clear up the line ending-only changes. Take a look at what seem like pointless local var assignments. No further review needed.

labkey-adam · 2026-05-11T17:28:53Z

-        setBackgroundColor(f.getBackgroundColor());
-        setFilter(f.getFilter());
-    }
-}


Line endings change?

Leaving as-is. Diffs and annotate looks fine in IntelliJ.

labkey-adam · 2026-05-11T17:29:02Z

-    {
-        return getPath();
-    }
-}


Line endings change?

labkey-adam · 2026-05-11T17:33:49Z

        PipelineJob job1 = this;
        List<String> errors = new ArrayList<>();
-        if (!PropertyUtil.nullSafeEquals(job1._activeTaskId, job2._activeTaskId))
+        if (!com.google.api.client.util.Objects.equal(job1._activeTaskId, job2._activeTaskId))


Should we just use the standard java.util.Objects.equals() instead? That's what this ends up calling.

Yes. Replaced.

labkey-adam · 2026-05-11T17:40:15Z

-        }
-        return null;
-    }
-}


Line endings changed

labkey-adam · 2026-05-11T17:40:27Z

-
-        return apiOverride;
-    }
-}


Line endings changed

labkey-adam · 2026-05-11T17:40:40Z

-    {
-        return _label;
-    }
-}


Line endings changed

labkey-adam · 2026-05-11T17:42:04Z

            //NOTE: the name of the assay PTID field might not always match ParticipantId.  this allows us to also
            //support PARTICIPANT_CONCEPT_URI
-            ColumnInfo ptidCol = selectColumns.stream().filter(c -> PropertyType.PARTICIPANT_CONCEPT_URI.equals(c.getConceptURI())).findFirst().orElse(null);
+            ColumnInfo ptidCol = selectColumns.stream().filter(c -> org.labkey.api.exp.PropertyType.PARTICIPANT_CONCEPT_URI.equals(c.getConceptURI())).findFirst().orElse(null);


Shouldn't need fully qualified class here since it's imported above

labkey-adam · 2026-05-11T17:48:20Z

                    boolean enrolledChanged = cohort.isEnrolled() != newEnrolled;
-                    boolean subjectCountChanged = !PropertyUtil.nullSafeEquals(cohort.getSubjectCount(), newSubjectCount);
-                    boolean desciprtionChanged = !Strings.CS.equals(cohort.getDescription(), newDescription);
+                    Object o1 = cohort.getSubjectCount();


Interesting that this one was pulled out into a var

Rolled back that part of the edit. Not sure how/why it happened.

labkey-adam · 2026-05-11T17:50:31Z

            Integer newSubjectCount = asInteger(row.get("subjectCount"));
            String newDescription = (String)row.get("description");

+            Object o3 = cohort.getSubjectCount();


Another interesting choice. Especially since the usage below would short-circuit in some cases and not execute this line. Not that it would use many cycles, but...

Rolled back that part of the edit. Not sure how/why it happened.

#### Rationale We're completely eliminating GWT from our codebase so there's no need to have any test references to it. #### Related Pull Requests - LabKey/platform#7659 #### Changes - Get rid of some locators - Expunge some GWT-specific workarounds - Eliminate some lint

labkey-jeckels added 20 commits April 24, 2026 20:49

Switch from GWT to React

b0ca7b8

Auto code review and comments

ca99f5e

Test fixes

a4b284f

Other cleanup

0622405

Improve generics for plate code

19e61e8

Merge branch 'refs/heads/develop' into fb_reactPlateDesigner

136e9f8

Unit tests and other improvements

a912417

Another checkpoint

6851d9c

Merge branch 'develop' into fb_reactPlateDesigner

6eea87a

Code review improvements, generics updates

28daef7

Unit test fixup, bounds validation

82f1f83

Merge branch 'develop' into fb_reactPlateDesigner

507c281

Manual test and code review feedback

3cdf006

Delete GWT

ab53b99

Delete GWT

e35f1d9

Delete GWT

7e0e4a9

More cleanup

ab2a11c

Delete GWT

c1d4962

Fix saving an assay design

41712c1

labkey-jeckels self-assigned this May 8, 2026

This was referenced May 8, 2026

Update JSON serialization for GWT removal LabKey/snprcEHRModules#930

Merged

Remove GWT styles LabKey/labkey-ui-components#2000

Merged

Minor cleanup

56353fa

labkey-jeckels mentioned this pull request May 8, 2026

Remove versions for GWT and Jakarta annotations LabKey/server#1368

Merged

Remove GWT references

b8a480b

labkey-jeckels mentioned this pull request May 8, 2026

Remove GWT references LabKey/testAutomation#2987

Merged

Merge branch 'develop' into fb_gwtDelete

317d077

labkey-jeckels requested a review from a team May 11, 2026 02:56

labkey-adam approved these changes May 11, 2026

View reviewed changes

Code review improvements

73bcd13

labkey-jeckels merged commit 97f8f2e into develop May 11, 2026
11 of 14 checks passed

labkey-jeckels deleted the fb_gwtDelete branch May 11, 2026 23:54

Conversation

labkey-jeckels commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale

Changes

Tasks 📍

Uh oh!

labkey-jeckels commented May 8, 2026

Uh oh!

labkey-adam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

labkey-jeckels commented May 8, 2026 •

edited

Loading