Fix tests to catch issue #1146#2994
Open
DariaBod wants to merge 1 commit into
Open
Conversation
labkey-tchad
approved these changes
May 13, 2026
| List<WebElement> dashboardIcons = elementCache().dashboardIconLoc.findElements(elementCache().menuContent); | ||
| for (WebElement dashboardIcon : dashboardIcons) | ||
| { | ||
| getWrapper().mouseOver(dashboardIcon.findElement(By.xpath("./ancestor::li[1]"))); |
Member
There was a problem hiding this comment.
Not super important for a use like this but we usually prefer to use Locator.xpath().findElement(context) instead of context.findElement(By.xpath). Locator.findElement wraps the resulting WebElement with a decorator that handles click interception (ReclickingWebElement).
Suggested change
| getWrapper().mouseOver(dashboardIcon.findElement(By.xpath("./ancestor::li[1]"))); | |
| getWrapper().mouseOver(Locator.xpath("./ancestor::li[1]").findElement(dashboardIcon)); |
| clickNavLink(elementCache().activeDashboardIcon); | ||
| } | ||
|
|
||
| // Interactions with icon elements on the page to catch GitHub Issue 1146. |
Member
There was a problem hiding this comment.
This comment describes that mouseOver, not the whole method. Move it closer to the line where the interaction is happening.
labkey-danield
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Interactions with icon elements on the page to catch GitHub Issue 1146.
Related Pull Requests
Changes