Skip to content

fix/115/prf menu <ul /> & respective child tags refined#128

Open
M-lakshan wants to merge 4 commits intoLeadCMS:developfrom
M-lakshan:fix/115/prf_cntx_menu_markup_hovering_refinement
Open

fix/115/prf menu <ul /> & respective child tags refined#128
M-lakshan wants to merge 4 commits intoLeadCMS:developfrom
M-lakshan:fix/115/prf_cntx_menu_markup_hovering_refinement

Conversation

@M-lakshan
Copy link
Copy Markdown
Contributor

@M-lakshan M-lakshan commented Sep 4, 2025

cause: prf component (ul-tag) top & bottom paddings were collided with the child elements (li-tag) own padding values. the divisor margins was also miss-aligned

refinement:

  • removed all padding values from main container (ul-tag)
  • removed the margin values from the divisor (hr-tag)
  • increased the child tags hovering visibility/contrast by +0.01(alpha-only) in the RGBa scale
  • gave a general padding to all children elms
  • replace all the padding values from first & last li-tag to be match with container

@M-lakshan M-lakshan changed the title prf menu <ul /> & respective child tags refined fix/115/prf menu <ul /> & respective child tags refined Sep 4, 2025
@DilhanRubera
Copy link
Copy Markdown
Contributor

DilhanRubera commented Sep 7, 2025

Move the "AccountMenu" styling into the dedicated styling file for dropdown menu called "index.styled.tsx" in the dropdown menu folder

Remove first of type and last of type padding since the Menu item root padding makes it look identical

Try to use the background colour from the theme provider file since we declare it there. Check subtitle2 colour

Remove redundant comments like "//

  • tags"

    Remove duplicate log out menu item

  • Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants