Skip to content

Update batch.lisp#6

Merged
snunez1 merged 2 commits into
Lisp-Stat:masterfrom
GongYiLiao:remove-iqr-alias
May 17, 2026
Merged

Update batch.lisp#6
snunez1 merged 2 commits into
Lisp-Stat:masterfrom
GongYiLiao:remove-iqr-alias

Conversation

@GongYiLiao
Copy link
Copy Markdown
Contributor

remove the iqr alias at the end since this package does not export IQR

remove the iqr alias at the end since this package does not export IQR
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@LEHunter
Copy link
Copy Markdown
Collaborator

LEHunter commented May 9, 2026

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@GongYiLiao
Copy link
Copy Markdown
Contributor Author

GongYiLiao commented May 10, 2026

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 10, 2026
@snunez1
Copy link
Copy Markdown
Contributor

snunez1 commented May 10, 2026

Thank very much for this. I think perhaps a better option is to export iqr. I would probably do this in src/batch.lisp:

;;; Helpful shortcuts
(defalias iqr interquartile-range)
(export 'iqr)

Do you want to update this PR please?

@snunez1
Copy link
Copy Markdown
Contributor

snunez1 commented May 10, 2026

@LEHunter , I'm glad you're back! I was just considering how to integrate your prior work into the batch statistics system. What do you think of converting the list-based input parameters into vector based ones? We could use the elementwise mathematics functions of numerical-utilities to smooth out the loops and syntax.

@LEHunter
Copy link
Copy Markdown
Collaborator

LEHunter commented May 10, 2026 via email

@snunez1
Copy link
Copy Markdown
Contributor

snunez1 commented May 10, 2026

It's mostly performance; lists are elegant, but very slow. Vectors have also become the idiomatic data structure over the years.

@LEHunter
Copy link
Copy Markdown
Collaborator

LEHunter commented May 10, 2026 via email

@snunez1
Copy link
Copy Markdown
Contributor

snunez1 commented May 15, 2026

@GongYiLiao , can you update iqr with an export form?

updated per maintainer's recommendation
@snunez1 snunez1 merged commit 732705f into Lisp-Stat:master May 17, 2026
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants