Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the announcement banner to highlight a critical security update and adds detailed release notes for version 6.6.10.
- Update Announcement.astro to warn about a high-severity vulnerability in v6.6.9
- Add v6.6.10 release entry in docs/releases.md including vulnerability description, remediation steps, and credits
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/components/widgets/Announcement.astro | Replace v6.6.9 link with v6.6.10 CVE warning; retain old block as comment |
| docs/releases.md | Append new section for v6.6.10 with security fix details and instructions |
Comment on lines
+12
to
+15
| <!-- <a | ||
| href="https://github.com/LycheeOrg/Lychee/releases/tag/v6.6.10" | ||
| class="text-slate-200 hover:underline dark:text-slate-200 font-medium">Lychee 6.6.10 is now available! »</a | ||
| > --> |
There was a problem hiding this comment.
[nitpick] Remove the commented-out anchor block (lines 12–15) to avoid dead code and reduce clutter; version control history preserves the previous link.
Suggested change
| <!-- <a | |
| href="https://github.com/LycheeOrg/Lychee/releases/tag/v6.6.10" | |
| class="text-slate-200 hover:underline dark:text-slate-200 font-medium">Lychee 6.6.10 is now available! »</a | |
| > --> |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
d7415
approved these changes
Jun 17, 2025
|
|
||
| #### The vulnerability | ||
|
|
||
| This vulnerability miss-uses the `$path` variable sent to the server, which is used to access the photos via the `SecurePathController`. |
Contributor
There was a problem hiding this comment.
Suggested change
| This vulnerability miss-uses the `$path` variable sent to the server, which is used to access the photos via the `SecurePathController`. | |
| This vulnerability misuses the `$path` variable sent to the server, which is used to access the photos via the `SecurePathController`. |
| This vulnerability miss-uses the `$path` variable sent to the server, which is used to access the photos via the `SecurePathController`. | ||
| We wrongly assumed that `Storage::disk(StorageDiskType::LOCAL->value)->path($path);` was protected against path traversal attacks which lead to this vulnerability. | ||
|
|
||
| When both the encrypted links and the temporary links are disabled, it is possible to call the endpoint with fictuous path values. Ironically, by enabling either of the functionality, the endpoint becomes secure again. |
Contributor
There was a problem hiding this comment.
Suggested change
| When both the encrypted links and the temporary links are disabled, it is possible to call the endpoint with fictuous path values. Ironically, by enabling either of the functionality, the endpoint becomes secure again. | |
| When both the encrypted links and the temporary links are disabled, it is possible to call the endpoint with path values that are out of scope. Ironically, by enabling either of the functionality, the endpoint becomes secure again. |
?
|
|
||
| We applied defense in depth: | ||
|
|
||
| 1. when neither functionality are enabled, we direclty return a 401/403 error on any call to `/image/{path}`. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. when neither functionality are enabled, we direclty return a 401/403 error on any call to `/image/{path}`. | |
| 1. when neither functionality is enabled, we directly return a 401/403 error on any call to `/image/{path}`. |
| We applied defense in depth: | ||
|
|
||
| 1. when neither functionality are enabled, we direclty return a 401/403 error on any call to `/image/{path}`. | ||
| 2. when either of the functionality are enabled, we check that the `$path` value generated by `Storage::disk(StorageDiskType::LOCAL->value)->path($path);` is within the intended image directory. Should this happen, we return a 418 error code (I'm a teapot) which can later be used to detect malicious calls and combined with fail-2-ban to block the IP address of the attacker. |
Contributor
There was a problem hiding this comment.
Suggested change
| 2. when either of the functionality are enabled, we check that the `$path` value generated by `Storage::disk(StorageDiskType::LOCAL->value)->path($path);` is within the intended image directory. Should this happen, we return a 418 error code (I'm a teapot) which can later be used to detect malicious calls and combined with fail-2-ban to block the IP address of the attacker. | |
| 2. when either of the functionalities are enabled, we check that the `$path` value generated by `Storage::disk(StorageDiskType::LOCAL->value)->path($path);` is within the intended image directory. Should this happen, we return a 418 error code (I'm a teapot) which can later be used to detect malicious calls and combined with fail-2-ban to block the IP address of the attacker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.