Skip to content

Add targeted 1.20.2 hotbar click regression coverage#3099

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/fix-hotbar-equipping-issue
Draft

Add targeted 1.20.2 hotbar click regression coverage#3099
Copilot wants to merge 3 commits intomasterfrom
copilot/fix-hotbar-equipping-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

The reported 1.20.2 failure was a disconnect on /inventory 0 click when left-clicking or right-clicking NBT-heavy equippable/hotbar items, with the server rejecting the Click Container packet as oversized. Current HEAD no longer reproduces that failure, so this change adds focused coverage for the exact regression path.

  • Targeted regression coverage

    • Adds a dedicated integration script for the 1.20.2 hotbar click scenario:
      • equips named + enchanted hotbar items matching the issue shape
      • exercises both inventory 0 click 36 LeftClick and inventory 0 click 37 RightClick
      • verifies MCC remains connected and responsive after each click
  • Issue-shaped fixture setup

    • Uses survival-mode inventory state with:
      • a named/enchanted sword in hotbar slot 36
      • a named/enchanted chestplate in hotbar slot 37
    • Keeps the setup close to the original failure mode instead of relying on generic inventory smoke coverage
  • Regression signal

    • Asserts absence of the original disconnect/error signatures in MCC output, including oversized-packet decoder failures
    • Confirms post-click liveness through follow-up commands rather than only checking that the click command was sent
run_mcc_command "inventory 0 click 36 LeftClick"
run_mcc_command "hotbar_click_regression_leftclick_ok"

run_mcc_command "inventory 0 click 37 RightClick"
run_mcc_command "hotbar_click_regression_rightclick_ok"
run_mcc_command "debug state"

Copilot AI changed the title [WIP] Fix player kick issue when equipping items from hotbar Add targeted 1.20.2 hotbar click regression coverage May 7, 2026
Copilot AI requested a review from milutinke May 7, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] clicking an equippable item in the hotbar has the player kicked for 230 bytes extra whilst reading packet 13

2 participants