MDEV-39292 Debian build compiles Columnstore aarch64#4920
Merged
sanja-byelkin merged 2 commits intoMariaDB:10.6from Apr 16, 2026
Merged
MDEV-39292 Debian build compiles Columnstore aarch64#4920sanja-byelkin merged 2 commits intoMariaDB:10.6from
sanja-byelkin merged 2 commits intoMariaDB:10.6from
Conversation
But doesn't package it. The devel-6 branch of columnstore is in a low maintaince state. We can't readd aarch64. To prevent our CI resources building aarch64 columnstore on the 10.6 and 10.11 branches we adjust our autobake-deb.sh to keep the disable there. The version check to 10 is so that when this is merged to 11.4 it becomes no longer impacting.
grooverdan
added
the
MariaDB Foundation
vuvova
reviewed
Apr 16, 2026
| sed -e '/Package: mariadb-plugin-columnstore/,/^$/d' -i debian/control | ||
| echo >> debian/control | ||
| cat storage/columnstore/columnstore/debian/control >> debian/control | ||
| if [ "${MYSQL_VERSION_MAJOR:-not10}" != "10" ] || [ "$architecture" = amd64 ] |
Member
There was a problem hiding this comment.
instead of this check, I'd do something like
if grep -q "$architecture" storage/columnstore/columnstore/debian/controlit'll work in 10.6 and in later versions, future proof.
And it won't enable columnstore build on any other architecture that columnstore happen to build on but doesn't package (does it build on x32?)
Member
Author
There was a problem hiding this comment.
There's no x86_32 for CS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But doesn't package it. The devel-6 branch of columnstore is in a low maintaince state. We can't readd aarch64.
To prevent our CI resources building aarch64 columnstore on the 10.6 and 10.11 branches we adjust our autobake-deb.sh to keep the disable there.
The version check to 10 is so that when this is merged to 11.4 it becomes no longer impacting.